Fix incognito notification/cleanup for android multiwindow.

Fix incognito notification/cleanup for android multiwindow.

When moving an NTP (very specific to the NTP URL) across
CTA instances, it would put the ref in AsyncTabParams, but
would not use it when creating the tab in the second window.

This was bad because it kept a reference to the incognito
tab forever (preventing the profile from being deleted and
the notification from going away).

This also changes the PendingIntent flag to allow the
notification to take an action as long as it is visible
(then if cleaning up the incognito tabs fails the first
time, the second click might succeed).

BUG=673582, 673489
Committed: https://crrev.com/1a81653525d7b252a2d37e7c489604126d917984
Cr-Commit-Position: refs/heads/master@{#438648}

[Ted C, 2016-12-14 19:07:12]

tedchoc@chromium.org changed reviewers:
+ twellington@chromium.org

[Ted C, 2016-12-14 19:07:13]

PTAL

[Theresa, 2016-12-14 19:18:04]

lgtm

[Ted C, 2016-12-14 19:18:40]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2016-12-14 19:19:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:31:08]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ted C, 2016-12-14 21:38:27]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:39:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 22:19:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481751507574880, "parent_rev":
"58def4f230d4c0cd97c86c04f8a0f6e85e682426", "commit_rev":
"f1275ee45b7c6aa167900c2fac5f7515f6f1df91"}

[commit-bot: I haz the power, 2016-12-14 22:20:16]

Description was changed from

==========
Fix incognito notification/cleanup for android multiwindow.

When moving an NTP (very specific to the NTP URL) across
CTA instances, it would put the ref in AsyncTabParams, but
would not use it when creating the tab in the second window.

This was bad because it kept a reference to the incognito
tab forever (preventing the profile from being deleted and
the notification from going away).

This also changes the PendingIntent flag to allow the
notification to take an action as long as it is visible
(then if cleaning up the incognito tabs fails the first
time, the second click might succeed).

BUG=673582, 673489
==========

to

==========
Fix incognito notification/cleanup for android multiwindow.

When moving an NTP (very specific to the NTP URL) across
CTA instances, it would put the ref in AsyncTabParams, but
would not use it when creating the tab in the second window.

This was bad because it kept a reference to the incognito
tab forever (preventing the profile from being deleted and
the notification from going away).

This also changes the PendingIntent flag to allow the
notification to take an action as long as it is visible
(then if cleaning up the incognito tabs fails the first
time, the second click might succeed).

BUG=673582, 673489

Review-Url: https://codereview.chromium.org/2574143004
==========

[commit-bot: I haz the power, 2016-12-14 22:20:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 22:22:22]

Description was changed from

==========
Fix incognito notification/cleanup for android multiwindow.

When moving an NTP (very specific to the NTP URL) across
CTA instances, it would put the ref in AsyncTabParams, but
would not use it when creating the tab in the second window.

This was bad because it kept a reference to the incognito
tab forever (preventing the profile from being deleted and
the notification from going away).

This also changes the PendingIntent flag to allow the
notification to take an action as long as it is visible
(then if cleaning up the incognito tabs fails the first
time, the second click might succeed).

BUG=673582, 673489

Review-Url: https://codereview.chromium.org/2574143004
==========

to

==========
Fix incognito notification/cleanup for android multiwindow.

When moving an NTP (very specific to the NTP URL) across
CTA instances, it would put the ref in AsyncTabParams, but
would not use it when creating the tab in the second window.

This was bad because it kept a reference to the incognito
tab forever (preventing the profile from being deleted and
the notification from going away).

This also changes the PendingIntent flag to allow the
notification to take an action as long as it is visible
(then if cleaning up the incognito tabs fails the first
time, the second click might succeed).

BUG=673582, 673489

Committed: https://crrev.com/1a81653525d7b252a2d37e7c489604126d917984
Cr-Commit-Position: refs/heads/master@{#438648}
==========

[commit-bot: I haz the power, 2016-12-14 22:22:23]

Patchset 1 (id:??) landed as
https://crrev.com/1a81653525d7b252a2d37e7c489604126d917984
Cr-Commit-Position: refs/heads/master@{#438648}