Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2603773002: Make SubresourceFilter browsertests work with and without PersistentHistograms. (Closed)

Created:
3 years, 12 months ago by engedy
Modified:
3 years, 11 months ago
Reviewers:
dvadym
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SubresourceFilter browsertests work with and without PersistentHistograms. The PersistentHistograms feature is currently enabled through field trials, so it is not yet used on offical builders, where the fieldtrial_testing_config is not applied. Whether or not this feature is enabled affects how browser tests need to force-synchronize renderer-side histograms before samples can be verified on the browser-side. This CL makes Safe Browsing subresource filter browser tests support both methods. BUG=677020, 637415 Committed: https://crrev.com/9273ccb313e40ed1cf5fd6e049e7b63a6aeed933 Cr-Commit-Position: refs/heads/master@{#440759}

Patch Set 1 #

Patch Set 2 : Swap order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/subresource_filter/subresource_filter_browsertest.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
engedy
Vadym, could you please take a look?
3 years, 12 months ago (2016-12-27 16:32:07 UTC) #2
dvadym
LGTM
3 years, 12 months ago (2016-12-27 16:38:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603773002/20001
3 years, 12 months ago (2016-12-27 16:39:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-27 17:14:21 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9273ccb313e40ed1cf5fd6e049e7b63a6aeed933
Cr-Commit-Position: refs/heads/master@{#440759}

Powered by Google App Engine
This is Rietveld 408576698