Simplify content::AssociatedInterfaceProviderImpl

Simplify content::AssociatedInterfaceProviderImpl

This CL uses mojo::MakeRequestForTesting() to internally create the message pipe
on which mojom::AssociatedInterfaceProvider will be associated.

BUG=

Committed: https://crrev.com/4015f271f96b29f2f2a1a95b333056108d43dd93
Cr-Commit-Position: refs/heads/master@{#440829}

[leonhsl(Using Gerrit), 2016-12-27 08:42:36]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 08:42:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 09:37:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 09:37:18]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2016-12-27 09:52:04]

leon.han@intel.com changed reviewers:
+ rockot@chromium.org

[leonhsl(Using Gerrit), 2016-12-27 09:52:05]

Hi, Ken, I found mojo::MakeRequestForTesting() is useful to do the
simplification, would you PTAL at this? Thanks.

[Ken Rockot(use gerrit already), 2016-12-27 18:30:20]

lgtm

[leonhsl(Using Gerrit), 2016-12-28 02:10:48]

leon.han@intel.com changed reviewers:
+ kinuko@chromium.org

[leonhsl(Using Gerrit), 2016-12-28 02:10:49]

+kinuko@, Hi, Would you PTAL for //content OWNER review? Thanks.

[kinuko, 2016-12-28 02:47:24]

lgtm, assuming that the code path that is calling MakeRequestForTesting is for
testing only.

https://codereview.chromium.org/2603743002/diff/1/content/common/associated_i...
File content/common/associated_interface_provider_impl.cc (right):

https://codereview.chromium.org/2603743002/diff/1/content/common/associated_i...
content/common/associated_interface_provider_impl.cc:16:
mojo::MakeRequestForTesting(proxy));
Is this ctor mainly for testing?  ...looks like so.

[leonhsl(Using Gerrit), 2016-12-28 03:03:40]

Thanks all for kindly review. Will send to CQ now.

https://codereview.chromium.org/2603743002/diff/1/content/common/associated_i...
File content/common/associated_interface_provider_impl.cc (right):

https://codereview.chromium.org/2603743002/diff/1/content/common/associated_i...
content/common/associated_interface_provider_impl.cc:16:
mojo::MakeRequestForTesting(proxy));
On 2016/12/28 02:47:24, kinuko wrote:
> Is this ctor mainly for testing?  ...looks like so.

Yeah it's true, this ctor is only used from
AssociatedInterfaceProviderImpl::AssociatedInterfaceProviderImpl(), which is
only for testing environment.

[leonhsl(Using Gerrit), 2016-12-28 03:06:11]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2016-12-28 03:06:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 03:12:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482894371343400, "parent_rev":
"06395d6061224f690f197938c488be37120310a9", "commit_rev":
"8322baea4a28bd73847e4ca1d5ee81d1804383f5"}

[commit-bot: I haz the power, 2016-12-28 03:13:15]

Description was changed from

==========
Simplify content::AssociatedInterfaceProviderImpl

This CL uses mojo::MakeRequestForTesting() to internally create the message pipe
on which mojom::AssociatedInterfaceProvider will be associated.

BUG=
==========

to

==========
Simplify content::AssociatedInterfaceProviderImpl

This CL uses mojo::MakeRequestForTesting() to internally create the message pipe
on which mojom::AssociatedInterfaceProvider will be associated.

BUG=

Review-Url: https://codereview.chromium.org/2603743002
==========

[commit-bot: I haz the power, 2016-12-28 03:13:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:48:30]

Description was changed from

==========
Simplify content::AssociatedInterfaceProviderImpl

This CL uses mojo::MakeRequestForTesting() to internally create the message pipe
on which mojom::AssociatedInterfaceProvider will be associated.

BUG=

Review-Url: https://codereview.chromium.org/2603743002
==========

to

==========
Simplify content::AssociatedInterfaceProviderImpl

This CL uses mojo::MakeRequestForTesting() to internally create the message pipe
on which mojom::AssociatedInterfaceProvider will be associated.

BUG=

Committed: https://crrev.com/4015f271f96b29f2f2a1a95b333056108d43dd93
Cr-Commit-Position: refs/heads/master@{#440829}
==========

[commit-bot: I haz the power, 2017-01-02 15:48:30]

Patchset 1 (id:??) landed as
https://crrev.com/4015f271f96b29f2f2a1a95b333056108d43dd93
Cr-Commit-Position: refs/heads/master@{#440829}