Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2603713003: [Fetch API] Pass web-platform fetch/api/cors/cors-preflight.html. (Closed)

Created:
3 years, 12 months ago by dhna
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Fetch API] Pass web-platform fetch/api/cors/cors-preflight.html. The failures are because the expected result is a list of header names separated only be "," (comma), but Blink instead returns a list of header names separate by ", ". So I modify it from ", "(comma + space) to ","(comma). BUG=672656 Review-Url: https://codereview.chromium.org/2603713003 Cr-Commit-Position: refs/heads/master@{#442170} Committed: https://chromium.googlesource.com/chromium/src/+/0f762fedb8512772504cd5548b93f2523ec1e3a2

Patch Set 1 #

Patch Set 2 : Fix test. #

Patch Set 3 : fix CrossOriginAccessControlTest #

Messages

Total messages: 28 (21 generated)
dhna
tyoshino@ PTAL.
3 years, 12 months ago (2016-12-27 08:24:40 UTC) #5
dhna
On 2016/12/27 08:24:40, dhna wrote: > tyoshino@ > PTAL. Thanks, I will check it out ...
3 years, 11 months ago (2017-01-05 13:02:46 UTC) #11
dhna
On 2017/01/05 13:02:46, dhna wrote: > On 2016/12/27 08:24:40, dhna wrote: > > tyoshino@ > ...
3 years, 11 months ago (2017-01-05 19:49:12 UTC) #12
tyoshino (SeeGerritForStatus)
lgtm Thanks for working on this.
3 years, 11 months ago (2017-01-06 11:14:52 UTC) #17
dhna
On 2017/01/06 11:14:52, tyoshino wrote: > lgtm > > Thanks for working on this. Thanks, ...
3 years, 11 months ago (2017-01-07 17:47:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603713003/40001
3 years, 11 months ago (2017-01-07 17:47:17 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 17:51:12 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0f762fedb8512772504cd5548b93...

Powered by Google App Engine
This is Rietveld 408576698