Expose per-request referrer policy in devtools

Expose per-request referrer policy in devtools

BUG=676804
R=estark@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org

Committed: https://crrev.com/dfc503bbe19442dba1645b811133defa7e1224f4
Cr-Commit-Position: refs/heads/master@{#441050}

[jochen (gone - plz use gerrit), 2016-12-23 12:46:50]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 12:46:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 14:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 14:06:18]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-27 19:45:36]

lgtm

https://codereview.chromium.org/2603593002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/request-referrer-policy.html
(right):

https://codereview.chromium.org/2603593002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/request-referrer-policy.html:24:
"policies = [" + policies.map(p => "'" + p + "'").toString() + "]"
It would be easier to pass the policy string in sendRequest() instead of a
number.

https://codereview.chromium.org/2603593002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2603593002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:301: case
ReferrerPolicyDefault:
This looks to be handled on line 293.

[estark, 2016-12-29 16:16:12]

lgtm

[jochen (gone - plz use gerrit), 2017-01-02 07:38:05]

https://codereview.chromium.org/2603593002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/request-referrer-policy.html
(right):

https://codereview.chromium.org/2603593002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/request-referrer-policy.html:24:
"policies = [" + policies.map(p => "'" + p + "'").toString() + "]"
On 2016/12/27 at 19:45:36, dgozman wrote:
> It would be easier to pass the policy string in sendRequest() instead of a
number.

done

https://codereview.chromium.org/2603593002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2603593002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:301: case
ReferrerPolicyDefault:
On 2016/12/27 at 19:45:36, dgozman wrote:
> This looks to be handled on line 293.

removed the duplicate

[jochen (gone - plz use gerrit), 2017-01-02 07:38:09]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-01-02 07:38:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2603593002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2017-01-02 07:38:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-02 09:07:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483342689275900,
"parent_rev": "6ba521a4a99dad5104c5668e1b9f5ab6446bbb17", "commit_rev":
"c434935ba76aba09dd23e7f924ae419fd7ecb6d5"}

[commit-bot: I haz the power, 2017-01-02 09:08:41]

Description was changed from

==========
Expose per-request referrer policy in devtools

BUG=676804
R=estark@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org
==========

to

==========
Expose per-request referrer policy in devtools

BUG=676804
R=estark@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org

Review-Url: https://codereview.chromium.org/2603593002
==========

[commit-bot: I haz the power, 2017-01-02 09:08:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:55:00]

Description was changed from

==========
Expose per-request referrer policy in devtools

BUG=676804
R=estark@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org

Review-Url: https://codereview.chromium.org/2603593002
==========

to

==========
Expose per-request referrer policy in devtools

BUG=676804
R=estark@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org

Committed: https://crrev.com/dfc503bbe19442dba1645b811133defa7e1224f4
Cr-Commit-Position: refs/heads/master@{#441050}
==========

[commit-bot: I haz the power, 2017-01-02 15:55:01]

Patchset 2 (id:??) landed as
https://crrev.com/dfc503bbe19442dba1645b811133defa7e1224f4
Cr-Commit-Position: refs/heads/master@{#441050}