Source/platform/scroll/FramelessScrollView.cpp - Issue 260353003: isActiveFocus() is a more meaningful name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/FramelessScrollView.cpp

Issue 260353003: isActiveFocus() is a more meaningful name (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/scroll/FramelessScrollView.cpp

diff --git a/Source/platform/scroll/FramelessScrollView.cpp b/Source/platform/scroll/FramelessScrollView.cpp

index ce002fefaa49ef8dfc958baef9ebdb8776087644..57f588503b194e0750162cb8eda8549aacb8ce4a 100644

--- a/Source/platform/scroll/FramelessScrollView.cpp

+++ b/Source/platform/scroll/FramelessScrollView.cpp

@@ -50,7 +50,7 @@ void FramelessScrollView::invalidateScrollbarRect(Scrollbar* scrollbar, const In

invalidateRect(dirtyRect);

}

-bool FramelessScrollView::isActive() const

+bool FramelessScrollView::isActiveFocus() const

{

// FIXME

return true;

@@ -58,7 +58,7 @@ bool FramelessScrollView::isActive() const

bool FramelessScrollView::scrollbarsCanBeActive() const

{

- return isActive();

+ return isActiveFocus();

}

IntRect FramelessScrollView::scrollableAreaBoundingBox() const