Source/platform/scroll/ScrollableArea.h - Issue 260353003: isActiveFocus() is a more meaningful name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollableArea.h

Issue 260353003: isActiveFocus() is a more meaningful name (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/scroll/ScrollableArea.h

diff --git a/Source/platform/scroll/ScrollableArea.h b/Source/platform/scroll/ScrollableArea.h

index 6bc133068084f9a508144a798a89519fd03a4bed..76d27bf8af66567a31f1f84c50b74c7abfdbea2c 100644

--- a/Source/platform/scroll/ScrollableArea.h

+++ b/Source/platform/scroll/ScrollableArea.h

@@ -114,8 +114,7 @@ public:

const IntPoint& scrollOrigin() const { return m_scrollOrigin; }

bool scrollOriginChanged() const { return m_scrollOriginChanged; }

- // FIXME(bokan): Meaningless name, rename to isActiveFocus

- virtual bool isActive() const = 0;

+ virtual bool isActiveFocus() const = 0;

virtual int scrollSize(ScrollbarOrientation) const = 0;

virtual void invalidateScrollbar(Scrollbar*, const IntRect&);

virtual bool isScrollCornerVisible() const = 0;

« no previous file with comments | « Source/platform/scroll/FramelessScrollView.cpp ('k') | Source/platform/scroll/Scrollbar.cpp » ('j') | no next file with comments »