Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2603493002: Remove duplicate C++ implementation of Object.prototype.toString (Closed)

Created:
3 years, 12 months ago by adamk
Modified:
3 years, 12 months ago
Reviewers:
Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove duplicate C++ implementation of Object.prototype.toString The only caller was the API, and it can just as easily use the TurboFan version. R=franzih@chromium.org Review-Url: https://codereview.chromium.org/2603493002 Cr-Commit-Position: refs/heads/master@{#41962} Committed: https://chromium.googlesource.com/v8/v8/+/c5dd44c33174c64cf7a5dcab0a65e8517d2c0e26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -96 lines) Patch
M src/api.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
adamk
3 years, 12 months ago (2016-12-22 22:38:44 UTC) #1
Franzi
lgtm
3 years, 12 months ago (2016-12-23 08:39:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603493002/1
3 years, 12 months ago (2016-12-27 17:59:23 UTC) #8
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 18:28:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c5dd44c33174c64cf7a5dcab0a65e8517d2...

Powered by Google App Engine
This is Rietveld 408576698