Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2603483002:
Convert realtimeanalyser-fft-sizing tst to testharness (Closed)
|
Created:
4 years ago by Raymond Toy Modified:
3 years, 11 months ago Reviewers:
hongchan CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConvert realtimeanalyser-fft-sizing tst to testharness
Test converted to use testharness and new Audit.
The expected result file is also removed.
BUG=675987
TEST=realtimeanalyser-fft-sizing.html
Committed: https://crrev.com/1ccc5796ad0f110d4638570b0bead2f197200ee3
Cr-Commit-Position: refs/heads/master@{#441442}
Patch Set 1 #Patch Set 2 : Indent and remove useless code #Patch Set 3 : Rebase #
Messages
Total messages: 15 (8 generated)
rtoy@chromium.org changed reviewers: + hongchan@chromium.org
PTAl. The current output is: This is a testharness.js-based test. PASS # AUDIT TASK RUNNER STARTED. PASS > [FFT size test] Test that re-sizing the FFT arrays does not fail. PASS Setting fftSize to -1 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (4294967295) is outside the range [32, 32768].". PASS Setting fftSize to 0 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (0) is outside the range [32, 32768].". PASS Setting fftSize to 1 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (1) is outside the range [32, 32768].". PASS Setting fftSize to 2 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (2) is outside the range [32, 32768].". PASS Setting fftSize to 3 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (3) is outside the range [32, 32768].". PASS Setting fftSize to 4 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (4) is outside the range [32, 32768].". PASS Setting fftSize to 5 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (5) is outside the range [32, 32768].". PASS Setting fftSize to 8 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (8) is outside the range [32, 32768].". PASS Setting fftSize to 9 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (9) is outside the range [32, 32768].". PASS Setting fftSize to 16 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (16) is outside the range [32, 32768].". PASS Setting fftSize to 17 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (17) is outside the range [32, 32768].". PASS Setting fftSize to 32 did not throw an exception. PASS Setting fftSize to 33 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (33) is not a power of two.". PASS Setting fftSize to 64 did not throw an exception. PASS Setting fftSize to 65 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (65) is not a power of two.". PASS Setting fftSize to 128 did not throw an exception. PASS Setting fftSize to 129 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (129) is not a power of two.". PASS Setting fftSize to 256 did not throw an exception. PASS Setting fftSize to 257 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (257) is not a power of two.". PASS Setting fftSize to 512 did not throw an exception. PASS Setting fftSize to 513 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (513) is not a power of two.". PASS Setting fftSize to 1024 did not throw an exception. PASS Setting fftSize to 1025 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (1025) is not a power of two.". PASS Setting fftSize to 2048 did not throw an exception. PASS Setting fftSize to 2049 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (2049) is not a power of two.". PASS Setting fftSize to 4096 did not throw an exception. PASS Setting fftSize to 4097 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (4097) is not a power of two.". PASS Setting fftSize to 8192 did not throw an exception. PASS Setting fftSize to 8193 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (8193) is not a power of two.". PASS Setting fftSize to 16384 did not throw an exception. PASS Setting fftSize to 16385 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The value provided (16385) is not a power of two.". PASS Setting fftSize to 32768 did not throw an exception. PASS Setting fftSize to 32769 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (32769) is outside the range [32, 32768].". PASS Setting fftSize to 65536 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (65536) is outside the range [32, 32768].". PASS Setting fftSize to 65537 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (65537) is outside the range [32, 32768].". PASS Setting fftSize to 131072 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (131072) is outside the range [32, 32768].". PASS Setting fftSize to 131073 threw IndexSizeError: "Failed to set the 'fftSize' property on 'AnalyserNode': The FFT size provided (131073) is outside the range [32, 32768].". PASS < [FFT size test] All assertions passed. (total 37 assertions) PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully. Harness: the test ran to completion.
lgtm
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by rtoy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hongchan@chromium.org Link to the patchset: https://codereview.chromium.org/2603483002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483556304913220,
"parent_rev": "560a290e84695e38b7ba64388c48cb459fd02350", "commit_rev":
"9426c6737ac281cbd552816b7ca365f1cc992e48"}
Message was sent while issue was closed.
Description was changed from ========== Convert realtimeanalyser-fft-sizing tst to testharness Test converted to use testharness and new Audit. The expected result file is also removed. BUG=675987 TEST=realtimeanalyser-fft-sizing.html ========== to ========== Convert realtimeanalyser-fft-sizing tst to testharness Test converted to use testharness and new Audit. The expected result file is also removed. BUG=675987 TEST=realtimeanalyser-fft-sizing.html Review-Url: https://codereview.chromium.org/2603483002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Convert realtimeanalyser-fft-sizing tst to testharness Test converted to use testharness and new Audit. The expected result file is also removed. BUG=675987 TEST=realtimeanalyser-fft-sizing.html Review-Url: https://codereview.chromium.org/2603483002 ========== to ========== Convert realtimeanalyser-fft-sizing tst to testharness Test converted to use testharness and new Audit. The expected result file is also removed. BUG=675987 TEST=realtimeanalyser-fft-sizing.html Committed: https://crrev.com/1ccc5796ad0f110d4638570b0bead2f197200ee3 Cr-Commit-Position: refs/heads/master@{#441442} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1ccc5796ad0f110d4638570b0bead2f197200ee3 Cr-Commit-Position: refs/heads/master@{#441442} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
