Re-enable fetching component policies for login screen apps

Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304, 666720
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policy
     and check that the device policies were fetched successfully

Committed: https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3
Cr-Commit-Position: refs/heads/master@{#441015}

[emaxx, 2016-12-23 15:00:36]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 15:00:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emaxx, 2016-12-23 15:08:09]

emaxx@chromium.org changed reviewers:
+ tnagel@chromium.org

[emaxx, 2016-12-23 15:08:10]

Thiemo, PTAL.

[commit-bot: I haz the power, 2016-12-23 15:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 15:31:36]

Dry run: This issue passed the CQ dry run.

[emaxx, 2016-12-27 13:46:57]

Description was changed from

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304
TEST=browser tests;
     manual test: sign into an enrolled device, go to chrome://policies
     and check that the device policies were fetched successfully
==========

to

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=browser tests;
     manual test: sign into an enrolled device, go to chrome://policies
     and check that the device policies were fetched successfully
==========

[emaxx, 2016-12-27 13:47:32]

Description was changed from

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=browser tests;
     manual test: sign into an enrolled device, go to chrome://policies
     and check that the device policies were fetched successfully
==========

to

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policies
     and check that the device policies were fetched successfully
==========

[emaxx, 2016-12-27 13:48:45]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 13:49:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 14:17:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 14:17:01]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2016-12-29 17:05:21]

lgtm

https://codereview.chromium.org/2603463003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
(right):

https://codereview.chromium.org/2603463003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h:179: bool
is_component_policy_enabled_ = true;
Nit: Maybe it would make sense to change polarity and rename to
"disable_component_policy_for_testing_"?

[emaxx, 2016-12-30 02:48:29]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-30 02:48:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emaxx, 2016-12-30 02:49:31]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-30 02:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emaxx, 2016-12-30 02:51:06]

Description was changed from

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policies
     and check that the device policies were fetched successfully
==========

to

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policy
     and check that the device policies were fetched successfully
==========

[commit-bot: I haz the power, 2016-12-30 03:15:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-30 03:15:08]

Dry run: This issue passed the CQ dry run.

[emaxx, 2016-12-30 03:24:27]

https://codereview.chromium.org/2603463003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
(right):

https://codereview.chromium.org/2603463003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h:179: bool
is_component_policy_enabled_ = true;
On 2016/12/29 17:05:21, Thiemo Nagel (slow) wrote:
> Nit: Maybe it would make sense to change polarity and rename to
> "disable_component_policy_for_testing_"?

Done. (Finally named "component_policy_disabled_for_testing".)

[emaxx, 2016-12-30 03:24:32]

The CQ bit was checked by emaxx@chromium.org

[emaxx, 2016-12-30 03:24:32]

The patchset sent to the CQ was uploaded after l-g-t-m from tnagel@chromium.org
Link to the patchset: https://codereview.chromium.org/2603463003/#ps40001
(title: "Rename the for-testing member")

[commit-bot: I haz the power, 2016-12-30 03:24:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 03:30:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483068272328620,
"parent_rev": "8f1f372431ab1084eecb9d91daf3b5edcb4d4838", "commit_rev":
"7321f64bc3fcb31beefb338a8661573153f9669d"}

[commit-bot: I haz the power, 2016-12-30 03:30:47]

Description was changed from

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policy
     and check that the device policies were fetched successfully
==========

to

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policy
     and check that the device policies were fetched successfully

Review-Url: https://codereview.chromium.org/2603463003
==========

[commit-bot: I haz the power, 2016-12-30 03:30:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-02 15:54:02]

Description was changed from

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policy
     and check that the device policies were fetched successfully

Review-Url: https://codereview.chromium.org/2603463003
==========

to

==========
Re-enable fetching component policies for login screen apps

This CL relands enabling fetching of policies for Chrome OS login screen
apps.

The originally landed code was temporarily disabled due to DMServer
responding with errors when an unknown policy type was requested. Now
this can be enabled back, after the DMServer got fixed to at least
ignore the new policy type (until it starts to actually provide policies
with this type).

BUG=644304,666720
TEST=re-enabled browser tests;
     manual test: sign into an enrolled device, go to chrome://policy
     and check that the device policies were fetched successfully

Committed: https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3
Cr-Commit-Position: refs/heads/master@{#441015}
==========

[commit-bot: I haz the power, 2017-01-02 15:54:03]

Patchset 3 (id:??) landed as
https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3
Cr-Commit-Position: refs/heads/master@{#441015}

[Thiemo Nagel, 2017-01-12 18:51:10]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2621413007/ by tnagel@chromium.org.

The reason for reverting is: I'm very sorry I have to revert this since it's
breaking device policy updates.

https://bugs.chromium.org/p/chromium/issues/detail?id=679956#c7.