Clang format JS: Disallow single line functions, conditionals, loops, and switch statements

Clang format JS: Disallow single line functions, conditionals, loops, and switch statements

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # ugh, those __getters__
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/55cf33bce9bcb48b733ff335b332aa5b985fc257
Cr-Commit-Position: refs/heads/master@{#440558}

[Dan Beam, 2016-12-22 19:47:01]

Description was changed from

==========
Disallow short functions on single lines

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
==========

to

==========
Disallow short functions on single lines

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-22 19:50:29]

Description was changed from

==========
Disallow short functions on single lines

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clang format JS: Disallow short functions on single lines

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-22 19:50:35]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 19:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 19:58:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 19:58:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-12-22 20:02:01]

Description was changed from

==========
Clang format JS: Disallow short functions on single lines

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clang format JS: Disallow single line functions, conditionals, loops, and switch
statements

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-22 20:29:46]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 20:30:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 20:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 20:37:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-12-22 20:37:58]

Description was changed from

==========
Clang format JS: Disallow single line functions, conditionals, loops, and switch
statements

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clang format JS: Disallow single line functions, conditionals, loops, and switch
statements

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # ugh, those __getters__
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-22 20:38:08]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 20:38:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-12-22 20:44:08]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-12-22 20:44:09]

lgtm

[commit-bot: I haz the power, 2016-12-22 21:57:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:57:15]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-12-22 22:34:27]

https://codereview.chromium.org/2603443002/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/chromeos/ui_account_tweaks.js (right):

https://codereview.chromium.org/2603443002/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/chromeos/ui_account_tweaks.js:29: }
Maybe add "Empty" (SFS_Empty) to AllowShortFunctionsOnASingleLine?

https://codereview.chromium.org/2603443002/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/list_selection_model.js (right):

https://codereview.chromium.org/2603443002/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/list_selection_model.js:340: });
Could this have a cr after the assignment?
i.e.   s/ = / =\n/

I don't know if there's a way to get clformat to do that though.

[Dan Beam, 2016-12-22 22:37:30]

https://codereview.chromium.org/2603443002/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/chromeos/ui_account_tweaks.js (right):

https://codereview.chromium.org/2603443002/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/chromeos/ui_account_tweaks.js:29: }
On 2016/12/22 22:34:27, dschuyler wrote:
> Maybe add "Empty" (SFS_Empty) to AllowShortFunctionsOnASingleLine?

Done.

[Dan Beam, 2016-12-22 23:33:18]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[dschuyler, 2016-12-22 23:33:38]

lgtm

[commit-bot: I haz the power, 2016-12-22 23:33:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-22 23:55:15]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-12-22 23:55:20]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-12-22 23:55:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2603443002/#ps60001
(title: "update c/b/r/ as well")

[commit-bot: I haz the power, 2016-12-22 23:55:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 00:34:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482450920265680,
"parent_rev": "6176c13e6c5307bda68bcd5981e96c5d86d7e0fc", "commit_rev":
"2aa5e86e335f3458f3752f55675a49c0564e124e"}

[commit-bot: I haz the power, 2016-12-23 00:34:34]

Description was changed from

==========
Clang format JS: Disallow single line functions, conditionals, loops, and switch
statements

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # ugh, those __getters__
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clang format JS: Disallow single line functions, conditionals, loops, and switch
statements

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # ugh, those __getters__
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2603443002
==========

[commit-bot: I haz the power, 2016-12-23 00:34:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-23 00:36:41]

Description was changed from

==========
Clang format JS: Disallow single line functions, conditionals, loops, and switch
statements

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # ugh, those __getters__
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2603443002
==========

to

==========
Clang format JS: Disallow single line functions, conditionals, loops, and switch
statements

This is to more easily set breakpoints.

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # ugh, those __getters__
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/55cf33bce9bcb48b733ff335b332aa5b985fc257
Cr-Commit-Position: refs/heads/master@{#440558}
==========

[commit-bot: I haz the power, 2016-12-23 00:36:43]

Patchset 4 (id:??) landed as
https://crrev.com/55cf33bce9bcb48b733ff335b332aa5b985fc257
Cr-Commit-Position: refs/heads/master@{#440558}