cros: Fix user image change crash

cros: Fix user image change crash

Make ChangePictureHandler and ProfileInfoHandler to use ScopedObserver
so that they are removed from UserManager's observer list when gone.

BUG=674841, 674786
Committed: https://crrev.com/638bc03b77fbd360784eabc823c2f2ecc62e4aa0
Cr-Commit-Position: refs/heads/master@{#441236}

[xiyuan, 2017-01-03 21:43:55]

Description was changed from

==========
cros: Fix user image change crash

Make ChangePictureHandler to use ScopedObserver so that it is removed
from UserManager's observer list when gone.

BUG=674841,674786
==========

to

==========
cros: Fix user image change crash

Make ChangePictureHandler and ProfileInfoHandler to use ScopedObserver
so that they are removed from UserManager's observer list when gone.

BUG=674841,674786
==========

[xiyuan, 2017-01-03 21:45:00]

xiyuan@chromium.org changed reviewers:
+ stevenjb@chromium.org

[xiyuan, 2017-01-03 21:45:05]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 21:45:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 21:47:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 21:47:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[stevenjb, 2017-01-03 21:54:44]

lgtm

[xiyuan, 2017-01-03 21:56:57]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2017-01-03 21:56:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2603423002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-03 21:57:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 22:59:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483480617033390,
"parent_rev": "ceab63c1177fd1565191169a601876b1d630e7d8", "commit_rev":
"164a269940440e4e767224fcdff3efb37ebcc544"}

[commit-bot: I haz the power, 2017-01-03 22:59:43]

Description was changed from

==========
cros: Fix user image change crash

Make ChangePictureHandler and ProfileInfoHandler to use ScopedObserver
so that they are removed from UserManager's observer list when gone.

BUG=674841,674786
==========

to

==========
cros: Fix user image change crash

Make ChangePictureHandler and ProfileInfoHandler to use ScopedObserver
so that they are removed from UserManager's observer list when gone.

BUG=674841,674786

Review-Url: https://codereview.chromium.org/2603423002
==========

[commit-bot: I haz the power, 2017-01-03 22:59:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2017-01-03 23:02:29]

Description was changed from

==========
cros: Fix user image change crash

Make ChangePictureHandler and ProfileInfoHandler to use ScopedObserver
so that they are removed from UserManager's observer list when gone.

BUG=674841,674786

Review-Url: https://codereview.chromium.org/2603423002
==========

to

==========
cros: Fix user image change crash

Make ChangePictureHandler and ProfileInfoHandler to use ScopedObserver
so that they are removed from UserManager's observer list when gone.

BUG=674841,674786

Committed: https://crrev.com/638bc03b77fbd360784eabc823c2f2ecc62e4aa0
Cr-Commit-Position: refs/heads/master@{#441236}
==========

[commit-bot: I haz the power, 2017-01-03 23:02:30]

Patchset 4 (id:??) landed as
https://crrev.com/638bc03b77fbd360784eabc823c2f2ecc62e4aa0
Cr-Commit-Position: refs/heads/master@{#441236}