Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2603403002: [ios] Removed CookieStoreIOS::SetSynchronizedWithSystemStore. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed CookieStoreIOS::SetSynchronizedWithSystemStore. This method is unused anymore. Also removed AddCookiesToSystemStore/RunAllPendingTasks methods and g_current_synchronized_store global variable. SYNCHRONIZING state and tasks_pending_synchronization_ will be removed in a separate CL. BUG=676144 Review-Url: https://codereview.chromium.org/2603403002 Cr-Commit-Position: refs/heads/master@{#442273} Committed: https://chromium.googlesource.com/chromium/src/+/bbd36820b3ac7b360ad6cbf351003f1c53b647a9

Patch Set 1 #

Patch Set 2 : Added back needed include #

Patch Set 3 : Removed g_current_synchronized_store #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -113 lines) Patch
M ios/net/cookies/cookie_store_ios.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 1 2 3 chunks +0 lines, -102 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-04 00:21:58 UTC) #16
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-09 09:40:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603403002/40001
3 years, 11 months ago (2017-01-09 16:53:57 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 17:06:18 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bbd36820b3ac7b360ad6cbf35100...

Powered by Google App Engine
This is Rietveld 408576698