Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 2603393002: The DOMRectReadOnly implementation are different with spec. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
haraken, zino
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The DOMRectReadOnly implementation are different with spec. The DOMRectReadOnly implementation are different with spec. They should match up with the spec[1]. The DOMRectReadOnly constructor should have default value. [1]https://drafts.fxtf.org/geometry/#dom-domrectreadonly-domrectreadonly BUG=678023 Review-Url: https://codereview.chromium.org/2603393002 Cr-Commit-Position: refs/heads/master@{#442163} Committed: https://chromium.googlesource.com/chromium/src/+/c883c90a96a245e289a850f2fd98584ff6098f92

Patch Set 1 #

Patch Set 2 : The DOMRect/DOMRectReadOnly implementation are different with spec. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMRectReadOnly.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-05 14:57:20 UTC) #5
zino
On 2017/01/05 14:57:20, Byoungkwon Ko wrote: > PTAL lgtm
3 years, 11 months ago (2017-01-06 20:26:23 UTC) #6
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-07 08:02:04 UTC) #8
haraken
LGTM
3 years, 11 months ago (2017-01-07 09:38:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603393002/20001
3 years, 11 months ago (2017-01-07 10:24:18 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 11:54:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c883c90a96a245e289a850f2fd98...

Powered by Google App Engine
This is Rietveld 408576698