Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2603343002: Emoji fixes: Two professions and digits with VS16 (Closed)

Created:
3 years, 11 months ago by drott
Modified:
3 years, 11 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Emoji fixes: Two professions and digits with VS16 Fixes for judge and pilot profession sequences as they were split by CachingWordShapeIterator. Also accept VS16 on keycap base characters 0-9,*,# as used on http://unicode.org/emoji/charts/full-emoji-list.html#0023_fe0f_20e3 BUG=628333, 675329 Committed: https://crrev.com/f176e05cf23ff77ceffda2e22caa0a71814bb403 Cr-Commit-Position: refs/heads/master@{#441123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/fonts/SymbolsIterator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.h View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
drott
3 years, 11 months ago (2017-01-03 12:15:12 UTC) #4
kojii
lgtm
3 years, 11 months ago (2017-01-03 15:00:42 UTC) #8
drott
Thanks for the quick review.
3 years, 11 months ago (2017-01-03 15:01:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603343002/1
3 years, 11 months ago (2017-01-03 15:01:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 15:05:14 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f176e05cf23ff77ceffda2e22caa0a71814bb403 Cr-Commit-Position: refs/heads/master@{#441123}
3 years, 11 months ago (2017-01-03 15:07:26 UTC) #16
eae
3 years, 11 months ago (2017-01-03 15:25:46 UTC) #17
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698