Disable tracking of visits to bookmarks in incognito

Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

Did not merge cleanly (with simple conflicts, though).
Compared to the original CL, this also adapts to a difference in the M56
branch from trunk - ntp_snippets::GetRecentlyVisitedBookmarks() takes 6
arguments.

BUG=662382, 677814
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)

Review-Url: https://codereview.chromium.org/2603323002

[jkrcal, 2017-01-03 10:17:33]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 10:17:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 10:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 10:17:46]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[jkrcal, 2017-01-03 10:19:37]

Description was changed from

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

Did not merge cleanly (with simple conflicts, though).
Compared to the original CL, this also adapts to a difference in the M56
branch from trunk - ntp_snippets::GetRecentlyVisitedBookmarks() takes 6
arguments.

BUG=662382

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)
==========

to

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

Did not merge cleanly (with simple conflicts, though).
Compared to the original CL, this also adapts to a difference in the M56
branch from trunk - ntp_snippets::GetRecentlyVisitedBookmarks() takes 6
arguments.

BUG=662382
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)
==========

[jkrcal, 2017-01-03 10:20:00]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 10:20:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 10:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 10:20:17]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2017-01-03 10:27:15]

Description was changed from

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

Did not merge cleanly (with simple conflicts, though).
Compared to the original CL, this also adapts to a difference in the M56
branch from trunk - ntp_snippets::GetRecentlyVisitedBookmarks() takes 6
arguments.

BUG=662382
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)
==========

to

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

Did not merge cleanly (with simple conflicts, though).
Compared to the original CL, this also adapts to a difference in the M56
branch from trunk - ntp_snippets::GetRecentlyVisitedBookmarks() takes 6
arguments.

BUG=662382, 677814
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)
==========

[jkrcal, 2017-01-03 10:36:38]

jkrcal@chromium.org changed reviewers:
+ avi@chromium.org, bauerb@chromium.org

[jkrcal, 2017-01-03 10:36:39]

Bernhard, Avi: I would like to reland a CL for the M56 branch that fixes a
privacy sensitive issue. Could you PTAL? (next beta should be released tomorrow)

I cannot run CQ / compile it locally. What are the rules, here?

[Bernhard Bauer, 2017-01-03 12:03:14]

LGTM, but for the next time it would be nice to see a diff to the previously
landed CL. You can upload that as the first patch set, then upload the fixed
version.

[jkrcal, 2017-01-03 14:50:07]

On 2017/01/03 12:03:14, Bernhard (just came back) wrote:
> LGTM, but for the next time it would be nice to see a diff to the previously
> landed CL. You can upload that as the first patch set, then upload the fixed
> version.

Thanks! Good point, I am sorry for the inconvenience.
In the mean-time I checked out the M56 branch and can confirm that with this CL
it compiles and passes unit-tests.

Avi, could you PTAL tab_helpers.cc?

[Avi (use Gerrit), 2017-01-03 16:34:47]

tab helpers lgtm

[jkrcal, 2017-01-03 16:42:47]

The CQ bit was checked by jkrcal@chromium.org

[commit-bot: I haz the power, 2017-01-03 16:43:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 16:44:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483461767655870, "parent_rev":
"6f1fa466849f3a1541e91319d25103c12c68e89c", "commit_rev":
"f81c79a8ae675ff8364f834ff1c0c479ada0351c"}

[commit-bot: I haz the power, 2017-01-03 16:44:32]

Description was changed from

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

Did not merge cleanly (with simple conflicts, though).
Compared to the original CL, this also adapts to a difference in the M56
branch from trunk - ntp_snippets::GetRecentlyVisitedBookmarks() takes 6
arguments.

BUG=662382, 677814
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)
==========

to

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

Did not merge cleanly (with simple conflicts, though).
Compared to the original CL, this also adapts to a difference in the M56
branch from trunk - ntp_snippets::GetRecentlyVisitedBookmarks() takes 6
arguments.

BUG=662382, 677814
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)

Review-Url: https://codereview.chromium.org/2603323002
==========

[commit-bot: I haz the power, 2017-01-03 16:44:33]

Committed patchset #1 (id:1)