Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2603313002: X87: [builtins] FastNewFunctionContextStub becomes a builtin. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
mvstanton, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] FastNewFunctionContextStub becomes a builtin. port f2e8c9786fdcc5f1cbb11676e9f4bfccada9b2d3 (r41988) original commit message: BUG= Review-Url: https://codereview.chromium.org/2603313002 Cr-Commit-Position: refs/heads/master@{#42019} Committed: https://chromium.googlesource.com/v8/v8/+/6ef22472c112f52d7c0263dfc29a781f6719ad05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-03 03:53:58 UTC) #2
chunyang.dai
On 2017/01/03 03:53:58, zhengxing.li wrote: > PTAL, thanks! LGTM thanks
3 years, 11 months ago (2017-01-03 05:07:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603313002/1
3 years, 11 months ago (2017-01-03 05:40:31 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 06:04:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6ef22472c112f52d7c0263dfc29a781f671...

Powered by Google App Engine
This is Rietveld 408576698