Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 2603153002: Use TaskScheduler instead of WorkerPool in arc_notification_item.cc. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in arc_notification_item.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. Does Not Block (default): Tasks without the MayBlock() and WithBaseSyncPrimitives() traits may not block. BUG=659191 Review-Url: https://codereview.chromium.org/2603153002 Cr-Commit-Position: refs/heads/master@{#441680} Committed: https://chromium.googlesource.com/chromium/src/+/e199d6993db574a00ccaffdd3a292347bd10e752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M ui/arc/notification/arc_notification_item.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fdoray
PTAL. WorkerPool is being deprecated in favor of TaskScheduler.
3 years, 11 months ago (2017-01-01 23:14:12 UTC) #6
yoshiki
lgtm
3 years, 11 months ago (2017-01-05 04:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603153002/1
3 years, 11 months ago (2017-01-05 16:39:11 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:16:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e199d6993db574a00ccaffdd3a29...

Powered by Google App Engine
This is Rietveld 408576698