Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: third_party/WebKit/Source/core/frame/FrameViewTest.cpp

Issue 2603063002: Only clear tooltip message on a user scroll or compositor scroll. (Closed)
Patch Set: Fix PLSA logic to include frame scrolls Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameViewTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
index 402a9695529fe7913067fe1e5ae281b91adb9f8c..b738cd1f610bc534a34a428d7d5e8c450ca3b859 100644
--- a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
@@ -119,6 +119,13 @@ TEST_P(FrameViewTest, HideTooltipWhenScrollPositionChanges) {
EXPECT_CALL(chromeClient(), mockSetToolTip(document().frame(), String(), _));
document().view()->layoutViewportScrollableArea()->setScrollOffset(
ScrollOffset(1, 1), UserScroll);
+
+ // Programmatic scrolling should not dismiss the tooltip, so setToolTip
+ // should not be called for this invocation.
+ EXPECT_CALL(chromeClient(), mockSetToolTip(document().frame(), String(), _))
+ .Times(0);
+ document().view()->layoutViewportScrollableArea()->setScrollOffset(
+ ScrollOffset(2, 2), ProgrammaticScroll);
}
// NoOverflowInIncrementVisuallyNonEmptyPixelCount tests fail if the number of
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTestHelper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698