third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2603063002: Only clear tooltip message on a user scroll or compositor scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2603063002: Only clear tooltip message on a user scroll or compositor scroll. (Closed)

Patch Set: Fix PLSA logic to include frame scrolls Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 7befa59cab9596c4259b88f2b9181b14a778f3c7..72dc3b2392bfb58cfd34830d30174a1014a5f2e1 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -3816,9 +3816,11 @@ void FrameView::updateScrollOffset(const ScrollOffset& offset,

document->enqueueScrollEventForNode(document);

m_frame->eventHandler().dispatchFakeMouseMoveEventSoon();

- Page* page = frame().page();

- if (page)

- page->chromeClient().clearToolTip(*m_frame);

+ if (scrollType == UserScroll || scrollType == CompositorScroll) {

+ Page* page = frame().page();

+ if (page)

+ page->chromeClient().clearToolTip(*m_frame);

+ }

LayoutViewItem layoutViewItem = document->layoutViewItem();

if (!layoutViewItem.isNull()) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameViewTest.cpp » ('j') | no next file with comments »