Add a Physical Web WebUI for Android

Add a Physical Web WebUI for Android

There is currently an Activity to display Physical Web URLs, but we'd
like do display those URLs from a WebUI.  In part, this will be simpler
for redirecting from the omnibox.  In part, it is simpler because we
no longer need an Activity and will be able to move away from it.  That
is, we originally need to display Physical Web URLs without the native
library loaded; this is no longer the case.

BUG=663842
Review-Url: https://codereview.chromium.org/2603043002
Cr-Commit-Position: refs/heads/master@{#441796}
Committed: https://chromium.googlesource.com/chromium/src/+/6de2a4029db400e3581fe6595aeb9c7f1960f22d

[cco3, 2016-12-29 22:19:59]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2017-01-04 01:27:41]

lgtm

[cco3, 2017-01-04 17:33:12]

cco3@chromium.org changed reviewers:
+ xiyuan@chromium.org

[cco3, 2017-01-04 17:33:12]

Hi xiyuan@, would you be able to review the three webui/ files?  Thank you!

[xiyuan, 2017-01-04 17:49:45]

webui lgtm

https://codereview.chromium.org/2603043002/diff/1/chrome/browser/ui/webui/phy...
File chrome/browser/ui/webui/physical_web/physical_web_ui.cc (right):

https://codereview.chromium.org/2603043002/diff/1/chrome/browser/ui/webui/phy...
chrome/browser/ui/webui/physical_web/physical_web_ui.cc:59: content::WebUI*
web_ui_;
nit: content::WebUI* const

[cco3, 2017-01-04 22:08:19]

https://codereview.chromium.org/2603043002/diff/1/chrome/browser/ui/webui/phy...
File chrome/browser/ui/webui/physical_web/physical_web_ui.cc (right):

https://codereview.chromium.org/2603043002/diff/1/chrome/browser/ui/webui/phy...
chrome/browser/ui/webui/physical_web/physical_web_ui.cc:59: content::WebUI*
web_ui_;
On 2017/01/04 17:49:45, xiyuan wrote:
> nit: content::WebUI* const

Done.

[cco3, 2017-01-04 22:08:26]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-04 22:08:27]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2603043002/#ps20001
(title: "Make WebUI const")

[commit-bot: I haz the power, 2017-01-04 22:09:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:14:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:14:04]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cco3, 2017-01-04 22:24:11]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-04 22:24:12]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2603043002/#ps40001
(title: "Add explicit dependency")

[commit-bot: I haz the power, 2017-01-04 22:24:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:40:30]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattreynolds, 2017-01-04 23:21:15]

https://codereview.chromium.org/2603043002/diff/40001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2603043002/diff/40001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:527:
"//components/physical_web/data_source:data_source",
When the target is the same as the final directory name you can omit the target,
eg this can be:
    "//components/physical_web/data_source",

https://codereview.chromium.org/2603043002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/physical_web/physical_web_ui.cc (right):

https://codereview.chromium.org/2603043002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/physical_web/physical_web_ui.cc:59: content::WebUI*
web_ui_ const;
content::WebUI* const web_ui_;

[cco3, 2017-01-05 05:26:20]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-05 05:26:21]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2603043002/#ps60001
(title: "(const correctly)")

[cco3, 2017-01-05 05:26:31]

The CQ bit was unchecked by cco3@chromium.org

[cco3, 2017-01-05 05:28:12]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-05 05:28:12]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2603043002/#ps70007
(title: "Dependency simplification")

[commit-bot: I haz the power, 2017-01-05 05:28:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 05:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 05:44:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cco3, 2017-01-05 18:03:11]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-05 18:03:12]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2603043002/#ps90001
(title: "Make kChromeUIPhysicalWebHost available on linux")

[commit-bot: I haz the power, 2017-01-05 18:03:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:18:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:18:08]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[cco3, 2017-01-05 18:42:40]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-05 18:42:40]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2603043002/#ps110001
(title: "More constants available on linux")

[commit-bot: I haz the power, 2017-01-05 18:43:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 20:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:03:15]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[cco3, 2017-01-05 20:14:51]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-05 20:14:51]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2603043002/#ps130001
(title: "Fix type cast issue")

[commit-bot: I haz the power, 2017-01-05 20:15:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 21:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 21:01:33]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cco3, 2017-01-05 21:29:38]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-05 21:29:38]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2603043002/#ps150001
(title: "static_cast")

[commit-bot: I haz the power, 2017-01-05 21:30:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 01:37:17]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1483651778469670,
"parent_rev": "116448501b2ceb72233df9dde44ed4b874ff1e25", "commit_rev":
"6de2a4029db400e3581fe6595aeb9c7f1960f22d"}

[commit-bot: I haz the power, 2017-01-06 01:37:46]

Description was changed from

==========
Add a Physical Web WebUI for Android

There is currently an Activity to display Physical Web URLs, but we'd
like do display those URLs from a WebUI.  In part, this will be simpler
for redirecting from the omnibox.  In part, it is simpler because we
no longer need an Activity and will be able to move away from it.  That
is, we originally need to display Physical Web URLs without the native
library loaded; this is no longer the case.

BUG=663842
==========

to

==========
Add a Physical Web WebUI for Android

There is currently an Activity to display Physical Web URLs, but we'd
like do display those URLs from a WebUI.  In part, this will be simpler
for redirecting from the omnibox.  In part, it is simpler because we
no longer need an Activity and will be able to move away from it.  That
is, we originally need to display Physical Web URLs without the native
library loaded; this is no longer the case.

BUG=663842

Review-Url: https://codereview.chromium.org/2603043002
Cr-Commit-Position: refs/heads/master@{#441796}
Committed:
https://chromium.googlesource.com/chromium/src/+/6de2a4029db400e3581fe6595aeb...
==========

[commit-bot: I haz the power, 2017-01-06 01:37:48]

Committed patchset #9 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/6de2a4029db400e3581fe6595aeb...