Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2603033002: [promises] Remove extra PromiseInit in InternalPromiseThen (Closed)

Created:
3 years, 11 months ago by gsathya
Modified:
3 years, 11 months ago
Reviewers:
caitp, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Remove extra PromiseInit in InternalPromiseThen R=adamk@chromium.org, caitp@igalia.com BUG=v8:5343 Review-Url: https://codereview.chromium.org/2603033002 Cr-Commit-Position: refs/heads/master@{#41995} Committed: https://chromium.googlesource.com/v8/v8/+/9d22fa3179ce48d41f404ee438304ee0a1a71194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/builtins/builtins-promise.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
gsathya
3 years, 11 months ago (2016-12-29 21:45:21 UTC) #3
adamk
lgtm
3 years, 11 months ago (2016-12-29 21:47:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603033002/1
3 years, 11 months ago (2016-12-29 22:10:27 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-29 22:14:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9d22fa3179ce48d41f404ee438304ee0a1a...

Powered by Google App Engine
This is Rietveld 408576698