Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2602993002: Fix build with system ICU (Closed)

Created:
3 years, 11 months ago by Paweł Hajdan Jr.
Modified:
3 years, 11 months ago
Reviewers:
drott
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build with system ICU Reported at https://bugs.gentoo.org/show_bug.cgi?id=602362 . BUG=none

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/text/CharacterEmoji.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (11 generated)
Paweł Hajdan Jr.
3 years, 11 months ago (2016-12-29 20:58:22 UTC) #6
drott
Thanks for trying to solve this, but I don't think this is the exactly right ...
3 years, 11 months ago (2016-12-30 14:07:08 UTC) #13
drott
3 years, 11 months ago (2017-01-02 13:12:01 UTC) #14
As Phajdan LGTM'ed the new proposal in
https://codereview.chromium.org/2606183002 I am closing this CL.

Powered by Google App Engine
This is Rietveld 408576698