Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2602943002: Fix flake in TabUsageRecorder egtests. (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flake in TabUsageRecorder egtests. - Switching of BVC is not always immediate. Add a Wait condition. - FastSwipe gesture sometimes fail to switch mode. Use SlowSwipe. Committed: https://crrev.com/12996a4d2d05517213a108aa81ef2a6b7c5c6172 Cr-Commit-Position: refs/heads/master@{#440949}

Patch Set 1 #

Patch Set 2 : BOOL -> bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm View 1 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Olivier
3 years, 11 months ago (2016-12-29 09:36:12 UTC) #2
marq (ping after 24h)
lgtm
3 years, 11 months ago (2016-12-29 09:49:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602943002/1
3 years, 11 months ago (2016-12-29 09:59:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/128712)
3 years, 11 months ago (2016-12-29 10:08:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602943002/20001
3 years, 11 months ago (2016-12-29 10:26:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-29 10:35:23 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12996a4d2d05517213a108aa81ef2a6b7c5c6172
Cr-Commit-Position: refs/heads/master@{#440949}

Powered by Google App Engine
This is Rietveld 408576698