Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2602933002: Unify texture and fbo creation for ES2 and ES3 in gl_tests (Closed)

Created:
3 years, 11 months ago by qiankun
Modified:
3 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify texture and fbo creation for ES2 and ES3 in gl_tests These are some reasons to do this: 1. Code can be shared between ES2 and ES3 tests. 2. We don't always create GL_TEXTURE_2D textures in test. 3. We may create textures many times in a single test. In such case, it's ugly to delete the textures created in Setup at the beginning of each test round. BUG=612542 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/563327d4d7c71b1e124f539fc6f598f92ced3043 Cr-Commit-Position: refs/heads/master@{#441297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -18 lines) Patch
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 26 chunks +55 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
qiankun
PTAL
3 years, 11 months ago (2016-12-29 09:46:37 UTC) #3
Zhenyao Mo
lgtm
3 years, 11 months ago (2017-01-03 22:23:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602933002/1
3 years, 11 months ago (2017-01-04 01:55:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 02:29:38 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 02:32:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/563327d4d7c71b1e124f539fc6f598f92ced3043
Cr-Commit-Position: refs/heads/master@{#441297}

Powered by Google App Engine
This is Rietveld 408576698