Issue 2602913002: Get rid of unused field has_compiled_code_ from the Isolate structure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2602913002: Get rid of unused field has_compiled_code_ from the Isolate structure. (Closed)

Created:
3 years, 11 months ago by siva

Modified:
3 years, 11 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Get rid of unused field has_compiled_code_ from the Isolate structure. This gets rid of the racy data update being done in set_has_compiled_code reported by TSAN. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/625ead0329688254634a9f44b5ae1c38c1d90655

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -9 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/precompiler.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

siva

3 years, 11 months ago (2016-12-29 18:08:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
625ead0329688254634a9f44b5ae1c38c1d90655 (presubmit successful).