Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: runtime/vm/isolate.h

Issue 2602913002: Get rid of unused field has_compiled_code_ from the Isolate structure. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef RUNTIME_VM_ISOLATE_H_ 5 #ifndef RUNTIME_VM_ISOLATE_H_
6 #define RUNTIME_VM_ISOLATE_H_ 6 #define RUNTIME_VM_ISOLATE_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "vm/atomic.h" 10 #include "vm/atomic.h"
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 ASSERT(debugger_ != NULL); 306 ASSERT(debugger_ != NULL);
307 return debugger_; 307 return debugger_;
308 } 308 }
309 309
310 void set_single_step(bool value) { single_step_ = value; } 310 void set_single_step(bool value) { single_step_ = value; }
311 bool single_step() const { return single_step_; } 311 bool single_step() const { return single_step_; }
312 static intptr_t single_step_offset() { 312 static intptr_t single_step_offset() {
313 return OFFSET_OF(Isolate, single_step_); 313 return OFFSET_OF(Isolate, single_step_);
314 } 314 }
315 315
316 void set_has_compiled_code(bool value) { has_compiled_code_ = value; }
317 bool has_compiled_code() const { return has_compiled_code_; }
318
319 // Lets the embedder know that a service message resulted in a resume request. 316 // Lets the embedder know that a service message resulted in a resume request.
320 void SetResumeRequest() { 317 void SetResumeRequest() {
321 resume_request_ = true; 318 resume_request_ = true;
322 set_last_resume_timestamp(); 319 set_last_resume_timestamp();
323 } 320 }
324 321
325 void set_last_resume_timestamp() { 322 void set_last_resume_timestamp() {
326 last_resume_timestamp_ = OS::GetCurrentTimeMillis(); 323 last_resume_timestamp_ = OS::GetCurrentTimeMillis();
327 } 324 }
328 325
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 uint64_t pause_capability_; 720 uint64_t pause_capability_;
724 uint64_t terminate_capability_; 721 uint64_t terminate_capability_;
725 bool errors_fatal_; 722 bool errors_fatal_;
726 void* init_callback_data_; 723 void* init_callback_data_;
727 Dart_EnvironmentCallback environment_callback_; 724 Dart_EnvironmentCallback environment_callback_;
728 Dart_LibraryTagHandler library_tag_handler_; 725 Dart_LibraryTagHandler library_tag_handler_;
729 ApiState* api_state_; 726 ApiState* api_state_;
730 Debugger* debugger_; 727 Debugger* debugger_;
731 bool resume_request_; 728 bool resume_request_;
732 int64_t last_resume_timestamp_; 729 int64_t last_resume_timestamp_;
733 bool has_compiled_code_; // Can check that no compilation occured.
734 Random random_; 730 Random random_;
735 Simulator* simulator_; 731 Simulator* simulator_;
736 Mutex* mutex_; // Protects compiler stats. 732 Mutex* mutex_; // Protects compiler stats.
737 Mutex* symbols_mutex_; // Protects concurrent access to the symbol table. 733 Mutex* symbols_mutex_; // Protects concurrent access to the symbol table.
738 Mutex* type_canonicalization_mutex_; // Protects type canonicalization. 734 Mutex* type_canonicalization_mutex_; // Protects type canonicalization.
739 Mutex* constant_canonicalization_mutex_; // Protects const canonicalization. 735 Mutex* constant_canonicalization_mutex_; // Protects const canonicalization.
740 Mutex* megamorphic_lookup_mutex_; // Protects megamorphic table lookup. 736 Mutex* megamorphic_lookup_mutex_; // Protects megamorphic table lookup.
741 MessageHandler* message_handler_; 737 MessageHandler* message_handler_;
742 IsolateSpawnState* spawn_state_; 738 IsolateSpawnState* spawn_state_;
743 bool is_runnable_; 739 bool is_runnable_;
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
993 intptr_t* spawn_count_; 989 intptr_t* spawn_count_;
994 990
995 Dart_IsolateFlags isolate_flags_; 991 Dart_IsolateFlags isolate_flags_;
996 bool paused_; 992 bool paused_;
997 bool errors_are_fatal_; 993 bool errors_are_fatal_;
998 }; 994 };
999 995
1000 } // namespace dart 996 } // namespace dart
1001 997
1002 #endif // RUNTIME_VM_ISOLATE_H_ 998 #endif // RUNTIME_VM_ISOLATE_H_
OLDNEW
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698