Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2602893002: [turbofan] Elide no-op adds in x64 index addressing modes (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Elide no-op adds in x64 index addressing modes Before this patch, Loads generated in the CSA on x64 that have a zero offset displacement will add a zero to the effective address rather than using an addressing mode that folds away the zero. This functionality already exists on ia32, but the port wasn't purely mechanical so it hadn't been done on x64. R=epertoso@chromium.org LOG=N Review-Url: https://codereview.chromium.org/2602893002 Cr-Commit-Position: refs/heads/master@{#41974} Committed: https://chromium.googlesource.com/v8/v8/+/1d96354714bda107bfef69fbbc1f0ee8f91fe6df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
danno
ptal
3 years, 11 months ago (2016-12-28 15:49:05 UTC) #3
epertoso
lgtm
3 years, 11 months ago (2016-12-28 15:52:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602893002/1
3 years, 11 months ago (2016-12-28 16:11:55 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 16:13:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1d96354714bda107bfef69fbbc1f0ee8f91...

Powered by Google App Engine
This is Rietveld 408576698