Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2602843002: Found a mistake. I should use a reference here. (Closed)

Created:
3 years, 12 months ago by cathiechentx
Modified:
3 years, 11 months ago
Reviewers:
pdr., skobes, Wei Xiaohai
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a reference in TextAutosizer::checkSuperclusterConsistency. BUG= Committed: https://crrev.com/688e7e1a92dc7780cebf1a7f3644ae5d83ad24e7 Cr-Commit-Position: refs/heads/master@{#440943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
cathiechentx
3 years, 12 months ago (2016-12-28 06:55:28 UTC) #4
skobes
lgtm For the change description I'd write something more specific like: "Use a reference in ...
3 years, 11 months ago (2016-12-28 18:37:57 UTC) #5
cathiechentx
On 2016/12/28 18:37:57, skobes wrote: > lgtm > > For the change description I'd write ...
3 years, 11 months ago (2016-12-29 04:59:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602843002/1
3 years, 11 months ago (2016-12-29 04:59:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 06:44:48 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/688e7e1a92dc7780cebf1a7f3644ae5d83ad24e7
Cr-Commit-Position: refs/heads/master@{#440943}

Powered by Google App Engine
This is Rietveld 408576698