Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 2602783002: Add flutter_engine runtime to the test script so we can run standard dart tests from the test suite… (Closed)
Patch Set: Address self code review. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 47b8a8791b67dcf9e333f435677375bbb708a3c2..c256d257666230e8cc37f213717c45ce18431e3b 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -208,6 +208,19 @@ abstract class TestSuite {
return dartExecutable;
}
+ /// Returns the name of the Sky shell executable.
Bill Hesse 2017/01/05 17:48:33 Should we use the name "flutter engine" everywhere
siva 2017/01/05 20:38:45 Done.
+ String get skyBinaryFileName {
+ // Controlled by user with the option "--engine".
+ String skyExecutable = configuration['engine'];
Bill Hesse 2017/01/05 17:48:33 If the default for this value in test_options was
siva 2017/01/05 20:38:45 Removed this default setting, the option is requir
+
+ if (skyExecutable == '') {
+ skyExecutable = 'sky_shell';
+ }
+
+ TestUtils.ensureExists(skyExecutable, configuration);
+ return skyExecutable;
+ }
+
String get dartVmNooptBinaryFileName {
// Controlled by user with the option "--dart".
String dartExecutable = configuration['dart'];
« tools/testing/dart/test_options.dart ('K') | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698