Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 2602783002: Add flutter_engine runtime to the test script so we can run standard dart tests from the test suite… (Closed)
Patch Set: Address self code review. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 String suffix = executableBinarySuffix; 201 String suffix = executableBinarySuffix;
202 dartExecutable = useSdk 202 dartExecutable = useSdk
203 ? '$buildDir/dart-sdk/bin/dart$suffix' 203 ? '$buildDir/dart-sdk/bin/dart$suffix'
204 : '$buildDir/dart$suffix'; 204 : '$buildDir/dart$suffix';
205 } 205 }
206 206
207 TestUtils.ensureExists(dartExecutable, configuration); 207 TestUtils.ensureExists(dartExecutable, configuration);
208 return dartExecutable; 208 return dartExecutable;
209 } 209 }
210 210
211 /// Returns the name of the Sky shell executable.
Bill Hesse 2017/01/05 17:48:33 Should we use the name "flutter engine" everywhere
siva 2017/01/05 20:38:45 Done.
212 String get skyBinaryFileName {
213 // Controlled by user with the option "--engine".
214 String skyExecutable = configuration['engine'];
Bill Hesse 2017/01/05 17:48:33 If the default for this value in test_options was
siva 2017/01/05 20:38:45 Removed this default setting, the option is requir
215
216 if (skyExecutable == '') {
217 skyExecutable = 'sky_shell';
218 }
219
220 TestUtils.ensureExists(skyExecutable, configuration);
221 return skyExecutable;
222 }
223
211 String get dartVmNooptBinaryFileName { 224 String get dartVmNooptBinaryFileName {
212 // Controlled by user with the option "--dart". 225 // Controlled by user with the option "--dart".
213 String dartExecutable = configuration['dart']; 226 String dartExecutable = configuration['dart'];
214 227
215 if (dartExecutable == '') { 228 if (dartExecutable == '') {
216 String suffix = executableBinarySuffix; 229 String suffix = executableBinarySuffix;
217 dartExecutable = useSdk 230 dartExecutable = useSdk
218 ? '$buildDir/dart-sdk/bin/dart_noopt$suffix' 231 ? '$buildDir/dart-sdk/bin/dart_noopt$suffix'
219 : '$buildDir/dart_noopt$suffix'; 232 : '$buildDir/dart_noopt$suffix';
220 } 233 }
(...skipping 2316 matching lines...) Expand 10 before | Expand all | Expand 10 after
2537 } 2550 }
2538 if (path.length > WINDOWS_SHORTEN_PATH_LIMIT) { 2551 if (path.length > WINDOWS_SHORTEN_PATH_LIMIT) {
2539 ++shortNameCounter; 2552 ++shortNameCounter;
2540 var pathEnd = path.substring(path.length - WINDOWS_PATH_END_LENGTH); 2553 var pathEnd = path.substring(path.length - WINDOWS_PATH_END_LENGTH);
2541 path = "short${shortNameCounter}_$pathEnd"; 2554 path = "short${shortNameCounter}_$pathEnd";
2542 } 2555 }
2543 } 2556 }
2544 return path; 2557 return path;
2545 } 2558 }
2546 } 2559 }
OLDNEW
« tools/testing/dart/test_options.dart ('K') | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698