Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2602743002: Disables PrivacyCollectionViewControllerTest.TestModel. (Closed)

Created:
3 years, 12 months ago by stkhapugin
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disables PrivacyCollectionViewControllerTest.TestModel. Disables this test because it fails on ios-canary. Filed a bug to track this disabled test (see BUG=). BUG=677121 Committed: https://crrev.com/0bda0dcb67594cef2a373139e0311c63c1817429 Cr-Commit-Position: refs/heads/master@{#440754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/chrome/browser/ui/settings/privacy_collection_view_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
stkhapugin
PTAL and check CQ if lgty
3 years, 12 months ago (2016-12-27 10:56:34 UTC) #2
marq (ping after 24h)
lgtm
3 years, 12 months ago (2016-12-27 13:30:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602743002/1
3 years, 12 months ago (2016-12-27 13:31:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 13:44:08 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bda0dcb67594cef2a373139e0311c63c1817429
Cr-Commit-Position: refs/heads/master@{#440754}

Powered by Google App Engine
This is Rietveld 408576698