Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2602713002: Subzero: Fix some build problems against LLVM trunk. (Closed)

Created:
3 years, 12 months ago by Jim Stichnoth
Modified:
3 years, 12 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix some build problems against LLVM trunk. This allows Subzero to build through LLVM e8516587a2604386a8faaab28c410663c2ec884c. 1. Mirror an internal change to the llvm::cl implementation. 2. Something changed in llvm::format() that now requires an explicit conversion from RegNumT. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=79810753afd2c8e7b0d04359481fa2ae4dac4bf2

Patch Set 1 #

Patch Set 2 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -17 lines) Patch
M src/IceClFlags.cpp View 1 2 chunks +20 lines, -0 lines 0 comments Download
M src/IceClFlags.def View 8 chunks +16 lines, -16 lines 0 comments Download
M src/IceRegAlloc.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
3 years, 12 months ago (2016-12-26 18:34:24 UTC) #3
Karl
lgtm
3 years, 12 months ago (2016-12-26 20:16:50 UTC) #4
Jim Stichnoth
3 years, 12 months ago (2016-12-26 22:16:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
79810753afd2c8e7b0d04359481fa2ae4dac4bf2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698