Issue 26027002: Add flag to pub serve to disable dart2js.

Issue 26027002: Add flag to pub serve to disable dart2js. (Closed)

Created:
7 years, 2 months ago by Bob Nystrom

Modified:
7 years, 2 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add flag to pub serve to disable dart2js. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=28288

Patch Set 2 : Revise. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -20 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback.dart	View		2 chunks	+5 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/serve.dart	View	1	4 chunks	+24 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/utils.dart	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_if_disabled_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

This gives user a simple way to opt out of dart2js in pub serve if ...

7 years, 2 months ago (2013-10-04 17:24:57 UTC) #1

nweiz

A couple suggestions, otherwise lgtm. https://codereview.chromium.org/26027002/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart File sdk/lib/_internal/pub/lib/src/command/serve.dart (right): https://codereview.chromium.org/26027002/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart#newcode35 sdk/lib/_internal/pub/lib/src/command/serve.dart:35: bool get useDart2js => ...

7 years, 2 months ago (2013-10-04 20:26:10 UTC) #2

Bob Nystrom

Committed patchset #2 manually as r28288 (presubmit successful).

7 years, 2 months ago (2013-10-04 22:35:39 UTC) #3

Bob Nystrom

7 years, 2 months ago (2013-10-04 23:23:59 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/26027002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/command/serve.dart (right):

https://codereview.chromium.org/26027002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/serve.dart:35: bool get useDart2js =>
commandOptions['dart2js'];
On 2013/10/04 20:26:10, nweiz wrote:
> I think this should be capitalized "useDart2JS". That's how it is in
> "Dart2JSTransformer", for example.

Done.

https://codereview.chromium.org/26027002/diff/1/sdk/lib/_internal/pub/test/se...
File sdk/lib/_internal/pub/test/serve/utils.dart (right):

https://codereview.chromium.org/26027002/diff/1/sdk/lib/_internal/pub/test/se...
sdk/lib/_internal/pub/test/serve/utils.dart:91: /// If [dart2js] is `false` does
not compiles Dart entrypoints in "web" to
On 2013/10/04 20:26:10, nweiz wrote:
> Comma after "`false`", "compiles" -> "compile".

Done.

Expand Messages | Collapse Messages