Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback.dart

Issue 26027002: Add flag to pub serve to disable dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/lib/src/command/serve.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback.dart b/sdk/lib/_internal/pub/lib/src/barback.dart
index 70b36b50b57b84db7415641d76a89ab36b8661fb..4ad50dc5813985dce0d17b47de5068b80627b42d 100644
--- a/sdk/lib/_internal/pub/lib/src/barback.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback.dart
@@ -9,8 +9,6 @@ import 'dart:async';
import 'package:barback/barback.dart';
import 'package:path/path.dart' as path;
-import 'barback/dart_forwarding_transformer.dart';
-import 'barback/dart2js_transformer.dart';
import 'barback/load_all_transformers.dart';
import 'barback/pub_package_provider.dart';
import 'barback/server.dart';
@@ -54,17 +52,14 @@ class TransformerId {
/// This transforms and serves all library and asset files in all packages in
/// [graph]. It loads any transformer plugins defined in packages in [graph] and
/// re-runs them as necessary when any input files change.
-Future<BarbackServer> createServer(String host, int port, PackageGraph graph) {
+///
+/// If [builtInTransformers] is provided, then a phase is added to the end of
+/// each package's cascade including those transformers.
+Future<BarbackServer> createServer(String host, int port, PackageGraph graph,
+ {Iterable<Transformer> builtInTransformers}) {
var provider = new PubPackageProvider(graph);
var barback = new Barback(provider);
- // TODO(rnystrom): Add dart2dart transformer here and some way to configure
- // them.
- var builtInTransformers = [
- new Dart2JSTransformer(graph),
- new DartForwardingTransformer()
- ];
-
return BarbackServer.bind(host, port, barback, graph.entrypoint.root.name)
.then((server) {
watchSources(graph, barback);
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/lib/src/command/serve.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698