Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2602663002: MediaSession should use ContextClient instead of ContextLifecycleObserver (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaSession should use ContextClient instead of ContextLifecycleObserver ContextClient is more lightweight than ContextLifecycleObserver. We prefer ContextClient. BUG=610176 Committed: https://crrev.com/71f33f82d2993c9aebb11b66c0389d7646c2817c Cr-Commit-Position: refs/heads/master@{#440708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/mediasession/MediaSession.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
3 years, 11 months ago (2016-12-26 06:15:04 UTC) #2
sof
lgtm
3 years, 11 months ago (2016-12-26 06:57:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602663002/1
3 years, 11 months ago (2016-12-26 07:12:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-26 10:06:28 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-26 10:09:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71f33f82d2993c9aebb11b66c0389d7646c2817c
Cr-Commit-Position: refs/heads/master@{#440708}

Powered by Google App Engine
This is Rietveld 408576698