Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2602603002: webrtc-internals: use spec event values (Closed)

Created:
3 years, 12 months ago by fippo
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webrtc-internals: use spec event values This maps the internal names of the values in the iceConnectionStateChange, iceGatheringStateChange and signalingStateChange to their equivalents defined in the specification. This is only done before displaying the values in order not to change the format of the JSON dump. BUG=678292 Committed: https://crrev.com/5934544dd649e157b0991d4ae6c295faf9c5d99d Cr-Commit-Position: refs/heads/master@{#441345}

Patch Set 1 #

Patch Set 2 : webrtc-internals: use spec event names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M content/browser/resources/media/peer_connection_update_table.js View 1 1 chunk +45 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hta - Chromium
lgtm Is this for what's displayed in webrtc-internals? If I read it correctly, it will ...
3 years, 11 months ago (2017-01-03 10:42:32 UTC) #3
fippo
On 2017/01/03 10:42:32, hta - Chromium wrote: > lgtm > > Is this for what's ...
3 years, 11 months ago (2017-01-03 13:40:51 UTC) #4
tommi (sloooow) - chröme
lgtm
3 years, 11 months ago (2017-01-04 08:59:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602603002/20001
3 years, 11 months ago (2017-01-04 09:00:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 09:09:18 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 09:11:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5934544dd649e157b0991d4ae6c295faf9c5d99d
Cr-Commit-Position: refs/heads/master@{#441345}

Powered by Google App Engine
This is Rietveld 408576698