Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2602553003: Remove base::ScopedPtrHashMap from components/prefs/. (Closed)

Created:
3 years, 12 months ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::ScopedPtrHashMap from components/prefs/. BUG=579229 Committed: https://crrev.com/ad545a861951c8d21403314f8c17e542368c1b9e Cr-Commit-Position: refs/heads/master@{#441444}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/prefs/pref_value_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/prefs/pref_value_map.cc View 5 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Avi (use Gerrit)
To anyone who's around this time of year.
3 years, 12 months ago (2016-12-24 03:42:14 UTC) #10
Avi (use Gerrit)
To any owner at all.
3 years, 11 months ago (2017-01-04 17:26:46 UTC) #12
battre
lgtm
3 years, 11 months ago (2017-01-04 17:30:47 UTC) #13
Avi (use Gerrit)
pastarmovj can you look at the changes in the chromeos file?
3 years, 11 months ago (2017-01-04 17:32:34 UTC) #15
pastarmovj
lgtm
3 years, 11 months ago (2017-01-04 18:43:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602553003/20001
3 years, 11 months ago (2017-01-04 18:45:26 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 20:10:00 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 20:12:30 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad545a861951c8d21403314f8c17e542368c1b9e
Cr-Commit-Position: refs/heads/master@{#441444}

Powered by Google App Engine
This is Rietveld 408576698