Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1837)

Unified Diff: components/offline_pages/core/offline_page_feature.cc

Issue 2602473004: Offline Page Cache uses user interaction triggers for saving pages. (Closed)
Patch Set: Rebased and added the other missing histogram.xml entry... Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/offline_page_feature.cc
diff --git a/components/offline_pages/core/offline_page_feature.cc b/components/offline_pages/core/offline_page_feature.cc
index ef2b4700ca49aa982799f4ad83b8f395822f47c7..452a1bacad559bde141de9ba8bf8f8ce85cbc150 100644
--- a/components/offline_pages/core/offline_page_feature.cc
+++ b/components/offline_pages/core/offline_page_feature.cc
@@ -16,6 +16,9 @@ const base::Feature kOfflineBookmarksFeature{"OfflineBookmarks",
const base::Feature kOffliningRecentPagesFeature{
"OfflineRecentPages", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kOffliningUsesNavigationTriggersFeature{
+ "OfflineRecentPagesNavigationTriggers", base::FEATURE_ENABLED_BY_DEFAULT};
+
const base::Feature kOfflinePagesCTFeature{"OfflinePagesCT",
base::FEATURE_ENABLED_BY_DEFAULT};
@@ -43,6 +46,16 @@ bool IsOffliningRecentPagesEnabled() {
return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature);
}
+bool IsOffliningRecentPagesUsingNavigationTriggers() {
+ return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature) &&
+ base::FeatureList::IsEnabled(kOffliningUsesNavigationTriggersFeature);
+}
+
+bool IsOffliningRecentPagesUsingInteractionTriggers() {
+ return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature) &&
+ !base::FeatureList::IsEnabled(kOffliningUsesNavigationTriggersFeature);
+}
+
bool IsOfflinePagesSvelteConcurrentLoadingEnabled() {
return base::FeatureList::IsEnabled(
kOfflinePagesSvelteConcurrentLoadingFeature);

Powered by Google App Engine
This is Rietveld 408576698