Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: components/offline_pages/core/offline_page_feature.cc

Issue 2602473004: Offline Page Cache uses user interaction triggers for saving pages. (Closed)
Patch Set: Rebased and added the other missing histogram.xml entry... Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/core/offline_page_feature.h" 5 #include "components/offline_pages/core/offline_page_feature.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/feature_list.h" 9 #include "base/feature_list.h"
10 10
11 namespace offline_pages { 11 namespace offline_pages {
12 12
13 const base::Feature kOfflineBookmarksFeature{"OfflineBookmarks", 13 const base::Feature kOfflineBookmarksFeature{"OfflineBookmarks",
14 base::FEATURE_DISABLED_BY_DEFAULT}; 14 base::FEATURE_DISABLED_BY_DEFAULT};
15 15
16 const base::Feature kOffliningRecentPagesFeature{ 16 const base::Feature kOffliningRecentPagesFeature{
17 "OfflineRecentPages", base::FEATURE_DISABLED_BY_DEFAULT}; 17 "OfflineRecentPages", base::FEATURE_DISABLED_BY_DEFAULT};
18 18
19 const base::Feature kOffliningUsesNavigationTriggersFeature{
20 "OfflineRecentPagesNavigationTriggers", base::FEATURE_ENABLED_BY_DEFAULT};
21
19 const base::Feature kOfflinePagesCTFeature{"OfflinePagesCT", 22 const base::Feature kOfflinePagesCTFeature{"OfflinePagesCT",
20 base::FEATURE_ENABLED_BY_DEFAULT}; 23 base::FEATURE_ENABLED_BY_DEFAULT};
21 24
22 const base::Feature kOfflinePagesSharingFeature{ 25 const base::Feature kOfflinePagesSharingFeature{
23 "OfflinePagesSharing", base::FEATURE_DISABLED_BY_DEFAULT}; 26 "OfflinePagesSharing", base::FEATURE_DISABLED_BY_DEFAULT};
24 27
25 const base::Feature kOfflinePagesSvelteConcurrentLoadingFeature{ 28 const base::Feature kOfflinePagesSvelteConcurrentLoadingFeature{
26 "OfflinePagesSvelteConcurrentLoading", base::FEATURE_DISABLED_BY_DEFAULT}; 29 "OfflinePagesSvelteConcurrentLoading", base::FEATURE_DISABLED_BY_DEFAULT};
27 30
28 const base::Feature kBackgroundLoaderForDownloadsFeature{ 31 const base::Feature kBackgroundLoaderForDownloadsFeature{
29 "BackgroundLoadingForDownloads", base::FEATURE_ENABLED_BY_DEFAULT}; 32 "BackgroundLoadingForDownloads", base::FEATURE_ENABLED_BY_DEFAULT};
30 33
31 const base::Feature kOfflinePagesAsyncDownloadFeature{ 34 const base::Feature kOfflinePagesAsyncDownloadFeature{
32 "OfflinePagesAsyncDownload", base::FEATURE_DISABLED_BY_DEFAULT}; 35 "OfflinePagesAsyncDownload", base::FEATURE_DISABLED_BY_DEFAULT};
33 36
34 const base::Feature kNewBackgroundLoaderFeature { 37 const base::Feature kNewBackgroundLoaderFeature {
35 "BackgroundLoader", base::FEATURE_DISABLED_BY_DEFAULT 38 "BackgroundLoader", base::FEATURE_DISABLED_BY_DEFAULT
36 }; 39 };
37 40
38 bool IsOfflineBookmarksEnabled() { 41 bool IsOfflineBookmarksEnabled() {
39 return base::FeatureList::IsEnabled(kOfflineBookmarksFeature); 42 return base::FeatureList::IsEnabled(kOfflineBookmarksFeature);
40 } 43 }
41 44
42 bool IsOffliningRecentPagesEnabled() { 45 bool IsOffliningRecentPagesEnabled() {
43 return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature); 46 return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature);
44 } 47 }
45 48
49 bool IsOffliningRecentPagesUsingNavigationTriggers() {
50 return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature) &&
51 base::FeatureList::IsEnabled(kOffliningUsesNavigationTriggersFeature);
52 }
53
54 bool IsOffliningRecentPagesUsingInteractionTriggers() {
55 return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature) &&
56 !base::FeatureList::IsEnabled(kOffliningUsesNavigationTriggersFeature);
57 }
58
46 bool IsOfflinePagesSvelteConcurrentLoadingEnabled() { 59 bool IsOfflinePagesSvelteConcurrentLoadingEnabled() {
47 return base::FeatureList::IsEnabled( 60 return base::FeatureList::IsEnabled(
48 kOfflinePagesSvelteConcurrentLoadingFeature); 61 kOfflinePagesSvelteConcurrentLoadingFeature);
49 } 62 }
50 63
51 bool IsOfflinePagesCTEnabled() { 64 bool IsOfflinePagesCTEnabled() {
52 return base::FeatureList::IsEnabled(kOfflinePagesCTFeature); 65 return base::FeatureList::IsEnabled(kOfflinePagesCTFeature);
53 } 66 }
54 67
55 bool IsOfflinePagesSharingEnabled() { 68 bool IsOfflinePagesSharingEnabled() {
56 return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature); 69 return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature);
57 } 70 }
58 71
59 bool IsBackgroundLoaderForDownloadsEnabled() { 72 bool IsBackgroundLoaderForDownloadsEnabled() {
60 return base::FeatureList::IsEnabled(kBackgroundLoaderForDownloadsFeature); 73 return base::FeatureList::IsEnabled(kBackgroundLoaderForDownloadsFeature);
61 } 74 }
62 75
63 bool IsOfflinePagesAsyncDownloadEnabled() { 76 bool IsOfflinePagesAsyncDownloadEnabled() {
64 return base::FeatureList::IsEnabled(kOfflinePagesAsyncDownloadFeature); 77 return base::FeatureList::IsEnabled(kOfflinePagesAsyncDownloadFeature);
65 } 78 }
66 79
67 bool ShouldUseNewBackgroundLoader() { 80 bool ShouldUseNewBackgroundLoader() {
68 return base::FeatureList::IsEnabled(kNewBackgroundLoaderFeature); 81 return base::FeatureList::IsEnabled(kNewBackgroundLoaderFeature);
69 } 82 }
70 83
71 } // namespace offline_pages 84 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698