Run tools/clang-format-js on chrome/browser/resources/net_internals

Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/8b5823b9d23459f582a59d1ece93a9308a0d2609
Cr-Commit-Position: refs/heads/master@{#441300}

[Dan Beam, 2016-12-23 01:52:12]

Description was changed from

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=mmenke@chromium.org
==========

to

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=mmenke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-23 01:55:44]

Description was changed from

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=mmenke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=mmenke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-23 01:55:44]

dbeam@chromium.org changed reviewers:
+ eroman@chromium.org
- mmenke@chromium.org

[Dan Beam, 2016-12-23 01:55:53]

Description was changed from

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=mmenke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-23 01:57:53]

General FAQ:

How do you create this diff?
tools/clang-format-js <dir_name>

Did you check it line-by-line?
Ehhhhh, kinda.

But I don't like part of it...
The ability to format JS automagically is awesome.  You might not like it now,
and if so: let's change a .clang-format somewhere.  But ultimately, having
auto-formatted JS is nicer than My Specific Nits.  or at least I think so ;)

I thought closure_linter was supposed to do this?
It was, until I removed it.
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/OTEfsPvp0qc

How do I ensure people use `git cl format` to keep this style?
You can use input_api.canned_checks.CheckPatchFormatted().  I hope to add this
to chrome/browser/resources/PRESUBMIT.py soon.

Can my directory change its style or opt out?
Yep, I can give you more details about this.  Just let me know.

[Dan Beam, 2016-12-23 01:57:57]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 01:58:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-12-23 02:38:44]

https://codereview.chromium.org/2602473003/diff/1/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/index.js (right):

https://codereview.chromium.org/2602473003/diff/1/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/index.js:5: // <include src="util.js">
I don't believe these changes here are correct.

[Dan Beam, 2016-12-23 02:41:25]

https://codereview.chromium.org/2602473003/diff/1/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/index.js (right):

https://codereview.chromium.org/2602473003/diff/1/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/index.js:5: // <include src="util.js">
On 2016/12/23 02:38:44, eroman (slow) wrote:
> I don't believe these changes here are correct.

why do you believe these are incorrect?  what do you think is happening?

note: grit doesn't care about // comments.  clang-format does.  so these files
are still inlined.  they also have copyrights on top (as must all .js files) so
you end up going from

// <include src="blah.js">

to

// // Copyright Chromium or whatever
// more copyright
// end copyright.

... contents of blah.js ...

if I *don't* comment out these lines, bad things happen.  I can show you if
you'd like.

[Dan Beam, 2016-12-23 02:42:45]

https://codereview.chromium.org/2602473003/diff/1/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/index.js (right):

https://codereview.chromium.org/2602473003/diff/1/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/index.js:5: // <include src="util.js">
On 2016/12/23 02:41:24, Dan Beam wrote:
> On 2016/12/23 02:38:44, eroman (slow) wrote:
> > I don't believe these changes here are correct.
> 
> why do you believe these are incorrect?  what do you think is happening?
> 
> note: grit doesn't care about // comments.  clang-format does.  so these files
> are still inlined.  they also have copyrights on top (as must all .js files)
so
> you end up going from
> 
> // <include src="blah.js">
> 
> to
> 
> // // Copyright Chromium or whatever
> // more copyright
> // end copyright.
> 
> ... contents of blah.js ...
> 
> if I *don't* comment out these lines, bad things happen.  I can show you if
> you'd like.

and while i don't totally love depending on this behavior:

a) it's enforced by tooling (i.e. .js files must have a copyright)
b) it's used a little bit already
https://cs.chromium.org/search/?q=%22//+%3Cinclude+src%22&sq=package:chromium...

[Dan Beam, 2016-12-23 02:53:39]

https://codereview.chromium.org/2602473003/diff/1/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/index.js (right):

https://codereview.chromium.org/2602473003/diff/1/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/index.js:5: // <include src="util.js">
On 2016/12/23 02:42:45, Dan Beam wrote:
> On 2016/12/23 02:41:24, Dan Beam wrote:
> > On 2016/12/23 02:38:44, eroman (slow) wrote:
> > > I don't believe these changes here are correct.
> > 
> > why do you believe these are incorrect?  what do you think is happening?
> > 
> > note: grit doesn't care about // comments.  clang-format does.  so these
files
> > are still inlined.  they also have copyrights on top (as must all .js files)
> so
> > you end up going from
> > 
> > // <include src="blah.js">
> > 
> > to
> > 
> > // // Copyright Chromium or whatever
> > // more copyright
> > // end copyright.
> > 
> > ... contents of blah.js ...
> > 
> > if I *don't* comment out these lines, bad things happen.  I can show you if
> > you'd like.
> 
> and while i don't totally love depending on this behavior:
> 
> a) it's enforced by tooling (i.e. .js files must have a copyright)
> b) it's used a little bit already
>
https://cs.chromium.org/search/?q=%22//+%3Cinclude+src%22&sq=package:chromium...

and if you were wondering, closure_linter had hacks for this, as does the
closure *compiler* :/

it's basically our fault for putting <if|include> into source code

though at least <if> is quite helpful

[eroman, 2016-12-23 03:14:12]

lgtm then

[commit-bot: I haz the power, 2016-12-23 03:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 03:25:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-12-28 19:32:49]

Description was changed from

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPS_CHECK=true
==========

[Dan Beam, 2017-01-03 19:52:26]

Description was changed from

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPS_CHECK=true
==========

to

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true
==========

[Dan Beam, 2017-01-03 19:52:30]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-01-03 19:52:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 22:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 22:07:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-01-04 01:26:51]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-04 01:26:52]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2602473003/#ps20001
(title: "drop dep")

[commit-bot: I haz the power, 2017-01-04 01:27:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 02:38:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483493211908110,
"parent_rev": "ecc6d571ec76109d9173e104a65f4795b07d5ee7", "commit_rev":
"94f348ff0caa847c5966ba953223d8b6eb76a82c"}

[commit-bot: I haz the power, 2017-01-04 02:38:31]

Description was changed from

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2602473003
==========

[commit-bot: I haz the power, 2017-01-04 02:38:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 02:43:08]

Description was changed from

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2602473003
==========

to

==========
Run tools/clang-format-js on chrome/browser/resources/net_internals

BUG=567770
R=eroman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/8b5823b9d23459f582a59d1ece93a9308a0d2609
Cr-Commit-Position: refs/heads/master@{#441300}
==========

[commit-bot: I haz the power, 2017-01-04 02:43:09]

Patchset 2 (id:??) landed as
https://crrev.com/8b5823b9d23459f582a59d1ece93a9308a0d2609
Cr-Commit-Position: refs/heads/master@{#441300}