Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2602473002: Remove retry for testUserGestureForIframeSubresource (Closed)

Created:
4 years ago by boliu
Modified:
4 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove retry for testUserGestureForIframeSubresource Theory is due to misconfigured device. See bug for details. BUG=653130 Committed: https://crrev.com/09c88537d125e970cfc1252735dda30b424a6f10 Cr-Commit-Position: refs/heads/master@{#440526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
boliu
ptal running 50x locally, although.. I just realized I should run it on n5, not ...
4 years ago (2016-12-22 22:09:16 UTC) #2
jbudorick
lgtm
4 years ago (2016-12-22 22:10:13 UTC) #3
boliu
ok, 50 iterations passed on n5 kitkat
4 years ago (2016-12-22 22:25:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602473002/1
4 years ago (2016-12-22 22:25:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 22:31:33 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 22:34:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09c88537d125e970cfc1252735dda30b424a6f10
Cr-Commit-Position: refs/heads/master@{#440526}

Powered by Google App Engine
This is Rietveld 408576698