Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2602433002: Revert of [heap] Ensure progress when incrementally marking wrappers (Closed)

Created:
4 years ago by Michael Lippautz
Modified:
4 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, haraken
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Ensure progress when incrementally marking wrappers (patchset #3 id:60001 of https://codereview.chromium.org/2592403002/ ) Reason for revert: This won't work because the finalization still checks whether both marking deques are empty, also calling into blink. So we never proceed there. Original issue's description: > [heap] Ensure progress when incrementally marking wrappers > > The problem here is estimating the marking step size for wrapper tracing. If the > steps are too small, we cannot keep up with the mutator creating new wrappers. > The result is an endless stream of incremental marking steps, alternating v8 and > wrappers tracing, without ever finalizing in a GC. > > The mitigation here is to abort finding the fix point after 10 incremental > iterations. > > A proper solution would track newly created wrappers on the blink side during > wrapper tracing. Will give this more thought after the holidays. > > BUG=chromium:668164, chromium:468240 > > Review-Url: https://codereview.chromium.org/2592403002 > Cr-Commit-Position: refs/heads/master@{#41923} > Committed: https://chromium.googlesource.com/v8/v8/+/a47417b89373c615f9256800cfc803d84ba58378 TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:668164, chromium:468240 Review-Url: https://codereview.chromium.org/2602433002 Cr-Commit-Position: refs/heads/master@{#41924} Committed: https://chromium.googlesource.com/v8/v8/+/73036fb6916e5b2d75db766d695ae7a45af138a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -25 lines) Patch
M src/heap/embedder-tracing.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/heap/embedder-tracing.cc View 3 chunks +1 line, -7 lines 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Lippautz
Created Revert of [heap] Ensure progress when incrementally marking wrappers
4 years ago (2016-12-22 15:07:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602433002/1
4 years ago (2016-12-22 15:07:29 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-22 15:07:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/73036fb6916e5b2d75db766d695ae7a45af...

Powered by Google App Engine
This is Rietveld 408576698