Push attributeName handling down into SVGAnimateElement

Push attributeName handling down into SVGAnimateElement

SVGAnimateElement (and derived classes) is where 'attributeName' has any
meaning. Move setting/updating of the resolved 'attributeName' value
there. This allows setAttributeName to be devirtualized.
Storage is kept at the SVGSMILElement level because of how it's used at
schedule/unschedule time.

BUG=641437
Committed: https://crrev.com/de098e0d9aa37e1db404b86ba5bfb1992008719a
Cr-Commit-Position: refs/heads/master@{#441356}

[fs, 2017-01-03 15:41:14]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 15:41:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 15:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 15:53:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-01-03 16:05:30]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 16:05:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 17:23:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 17:23:31]

Dry run: This issue passed the CQ dry run.

[fs, 2017-01-03 18:07:16]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[pdr., 2017-01-03 18:23:03]

LGTM

https://codereview.chromium.org/2602423002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp (right):

https://codereview.chromium.org/2602423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp:92: //  for targetting
the 'href' attribute."
Nit: extra space

[fs, 2017-01-04 09:37:08]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 09:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-01-04 09:37:36]

https://codereview.chromium.org/2602423002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp (right):

https://codereview.chromium.org/2602423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp:92: //  for targetting
the 'href' attribute."
On 2017/01/03 at 18:23:02, pdr. wrote:
> Nit: extra space

Removed.

[commit-bot: I haz the power, 2017-01-04 11:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 11:30:31]

Dry run: This issue passed the CQ dry run.

[fs, 2017-01-04 11:32:06]

The CQ bit was checked by fs@opera.com

[fs, 2017-01-04 11:32:06]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2602423002/#ps40001
(title: "Remove excess space")

[commit-bot: I haz the power, 2017-01-04 11:32:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 11:35:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483529526160060,
"parent_rev": "f2b32f19807984329663e1a63d098ba27b171ebc", "commit_rev":
"1b2939c1ef6de4981e0e88808b6f4dd156d3e78f"}

[commit-bot: I haz the power, 2017-01-04 11:36:23]

Description was changed from

==========
Push attributeName handling down into SVGAnimateElement

SVGAnimateElement (and derived classes) is where 'attributeName' has any
meaning. Move setting/updating of the resolved 'attributeName' value
there. This allows setAttributeName to be devirtualized.
Storage is kept at the SVGSMILElement level because of how it's used at
schedule/unschedule time.

BUG=641437
==========

to

==========
Push attributeName handling down into SVGAnimateElement

SVGAnimateElement (and derived classes) is where 'attributeName' has any
meaning. Move setting/updating of the resolved 'attributeName' value
there. This allows setAttributeName to be devirtualized.
Storage is kept at the SVGSMILElement level because of how it's used at
schedule/unschedule time.

BUG=641437

Review-Url: https://codereview.chromium.org/2602423002
==========

[commit-bot: I haz the power, 2017-01-04 11:36:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-04 11:38:03]

Description was changed from

==========
Push attributeName handling down into SVGAnimateElement

SVGAnimateElement (and derived classes) is where 'attributeName' has any
meaning. Move setting/updating of the resolved 'attributeName' value
there. This allows setAttributeName to be devirtualized.
Storage is kept at the SVGSMILElement level because of how it's used at
schedule/unschedule time.

BUG=641437

Review-Url: https://codereview.chromium.org/2602423002
==========

to

==========
Push attributeName handling down into SVGAnimateElement

SVGAnimateElement (and derived classes) is where 'attributeName' has any
meaning. Move setting/updating of the resolved 'attributeName' value
there. This allows setAttributeName to be devirtualized.
Storage is kept at the SVGSMILElement level because of how it's used at
schedule/unschedule time.

BUG=641437

Committed: https://crrev.com/de098e0d9aa37e1db404b86ba5bfb1992008719a
Cr-Commit-Position: refs/heads/master@{#441356}
==========

[commit-bot: I haz the power, 2017-01-04 11:38:05]

Patchset 3 (id:??) landed as
https://crrev.com/de098e0d9aa37e1db404b86ba5bfb1992008719a
Cr-Commit-Position: refs/heads/master@{#441356}