Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2602423002: Push attributeName handling down into SVGAnimateElement (Closed)

Created:
3 years, 11 months ago by fs
Modified:
3 years, 11 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push attributeName handling down into SVGAnimateElement SVGAnimateElement (and derived classes) is where 'attributeName' has any meaning. Move setting/updating of the resolved 'attributeName' value there. This allows setAttributeName to be devirtualized. Storage is kept at the SVGSMILElement level because of how it's used at schedule/unschedule time. BUG=641437 Committed: https://crrev.com/de098e0d9aa37e1db404b86ba5bfb1992008719a Cr-Commit-Position: refs/heads/master@{#441356}

Patch Set 1 #

Patch Set 2 : Move attributeName() accessor back #

Total comments: 2

Patch Set 3 : Remove excess space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -50 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 2 5 chunks +54 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 6 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
fs
3 years, 11 months ago (2017-01-03 18:07:17 UTC) #10
pdr.
LGTM https://codereview.chromium.org/2602423002/diff/20001/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp File third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp (right): https://codereview.chromium.org/2602423002/diff/20001/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp#newcode92 third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp:92: // for targetting the 'href' attribute." Nit: extra ...
3 years, 11 months ago (2017-01-03 18:23:03 UTC) #11
fs
https://codereview.chromium.org/2602423002/diff/20001/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp File third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp (right): https://codereview.chromium.org/2602423002/diff/20001/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp#newcode92 third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp:92: // for targetting the 'href' attribute." On 2017/01/03 at ...
3 years, 11 months ago (2017-01-04 09:37:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602423002/40001
3 years, 11 months ago (2017-01-04 11:32:14 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-04 11:36:24 UTC) #22
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 11:38:05 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/de098e0d9aa37e1db404b86ba5bfb1992008719a
Cr-Commit-Position: refs/heads/master@{#441356}

Powered by Google App Engine
This is Rietveld 408576698