Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 2602413002: [turbofan] Use graph assembler for memory optimizer. (Closed)

Created:
3 years, 11 months ago by Jarin
Modified:
3 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use graph assembler for memory optimizer. Review-Url: https://codereview.chromium.org/2602413002 Cr-Commit-Position: refs/heads/master@{#42041} Committed: https://chromium.googlesource.com/v8/v8/+/db13377fe81313924e06c1e70207088daffe73ca

Patch Set 1 #

Patch Set 2 : Refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -142 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/graph-assembler.h View 1 7 chunks +32 lines, -9 lines 0 comments Download
M src/compiler/graph-assembler.cc View 1 6 chunks +17 lines, -27 lines 0 comments Download
M src/compiler/memory-optimizer.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/memory-optimizer.cc View 1 7 chunks +78 lines, -105 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Jarin
Could you take a look, please?
3 years, 11 months ago (2017-01-03 15:35:54 UTC) #4
mvstanton
Very nice! LGTM.
3 years, 11 months ago (2017-01-03 15:47:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602413002/20001
3 years, 11 months ago (2017-01-03 17:05:34 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 17:29:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/db13377fe81313924e06c1e70207088daff...

Powered by Google App Engine
This is Rietveld 408576698