Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2602383003: PPC/s390: [Ignition] Teach CompileLazy about interpreted functions. (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [Ignition] Teach CompileLazy about interpreted functions. Port 72c370767226cf573d316655b1d3e3d3d699cc9b Original Commit Message: Currently the CompileLazy builtin checks the SFI expliciltly for FCG code. This means if the SFI has bytecode we have to go through to the runtime to install the interpreter entry trampoline into the JSFunction object. Modify the builtin to always put the SFI code object into the JSFunction unless it's the lazy compile stub on the SFI as well. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4380 LOG=N Review-Url: https://codereview.chromium.org/2602383003 Cr-Commit-Position: refs/heads/master@{#42046} Committed: https://chromium.googlesource.com/v8/v8/+/7d52258b1db78cf8de165f6494dd806d62ccbb81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-03 18:47:40 UTC) #1
JoranSiu
On 2017/01/03 18:47:40, JaideepBajwa wrote: > ptal lgtm
3 years, 11 months ago (2017-01-03 18:59:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602383003/1
3 years, 11 months ago (2017-01-03 19:02:45 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:27:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7d52258b1db78cf8de165f6494dd806d62c...

Powered by Google App Engine
This is Rietveld 408576698