Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2602363002: Always adjust container size when tracing HeapVectorBacking contents. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
haraken, keishi
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always adjust container size when tracing HeapVectorBacking contents. R=haraken BUG=677738 Committed: https://crrev.com/765e5dbf71e1b44b314694bc1935c30503fa0f35 Cr-Commit-Position: refs/heads/master@{#441107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sof
please take a look. i'm not OOO, so.. :)
3 years, 11 months ago (2017-01-03 07:56:54 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-03 08:14:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602363002/1
3 years, 11 months ago (2017-01-03 10:47:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 10:51:40 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 10:54:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/765e5dbf71e1b44b314694bc1935c30503fa0f35
Cr-Commit-Position: refs/heads/master@{#441107}

Powered by Google App Engine
This is Rietveld 408576698