Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260233002: [safe_browsing] Remove unused ContainsBrowseUrl() parameter. (Closed)

Created:
6 years, 7 months ago by Scott Hess - ex-Googler
Modified:
6 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews
Visibility:
Public.

Description

[safe_browsing] Remove unused ContainsBrowseUrl() parameter. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266896

Patch Set 1 #

Patch Set 2 : Did I forget one site? Yes, I did forget one site. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -95 lines) Patch
M chrome/browser/safe_browsing/database_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 22 chunks +50 lines, -82 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Scott Hess - ex-Googler
6 years, 7 months ago (2014-04-28 23:50:18 UTC) #1
mattm
lgtm
6 years, 7 months ago (2014-04-28 23:52:45 UTC) #2
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 7 months ago (2014-04-28 23:54:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/260233002/1
6 years, 7 months ago (2014-04-28 23:56:37 UTC) #4
Scott Hess - ex-Googler
The CQ bit was unchecked by shess@chromium.org
6 years, 7 months ago (2014-04-28 23:57:08 UTC) #5
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 7 months ago (2014-04-28 23:57:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/260233002/20001
6 years, 7 months ago (2014-04-28 23:58:38 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 00:56:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-29 00:56:44 UTC) #9
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 7 months ago (2014-04-29 04:31:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/260233002/20001
6 years, 7 months ago (2014-04-29 04:31:59 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 05:18:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-29 05:18:09 UTC) #13
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 7 months ago (2014-04-29 13:52:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/260233002/20001
6 years, 7 months ago (2014-04-29 13:53:18 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 16:22:05 UTC) #16
Message was sent while issue was closed. 
Change committed as 266896

Powered by Google App Engine
This is Rietveld 408576698