chrome/browser/safe_browsing/safe_browsing_database.cc - Issue 260233002: [safe_browsing] Remove unused ContainsBrowseUrl() parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.cc

Issue 260233002: [safe_browsing] Remove unused ContainsBrowseUrl() parameter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Did I forget one site? Yes, I did forget one site. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_database.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_database.cc b/chrome/browser/safe_browsing/safe_browsing_database.cc

index d783d12ef9e1d476470f7e113d5665d5fbddfbfb..5a43a715f2eee04c93f66515158f793b6e23b55f 100644

--- a/chrome/browser/safe_browsing/safe_browsing_database.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_database.cc

@@ -661,15 +661,12 @@ bool SafeBrowsingDatabaseNew::ResetDatabase() {

return true;

}

-// TODO(lzheng): Remove matching_list, it is not used anywhere.

bool SafeBrowsingDatabaseNew::ContainsBrowseUrl(

const GURL& url,

- std::string* matching_list,

std::vector<SBPrefix>* prefix_hits,

std::vector<SBFullHashResult>* full_hits,

base::Time last_update) {

// Clear the results first.

- matching_list->clear();

prefix_hits->clear();

full_hits->clear();