Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: net/cert_net/nss_ocsp_unittest.cc

Issue 2602243002: Use TaskScheduler instead of WorkerPool in multi_threaded_cert_verifier.cc. (Closed)
Patch Set: self-review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert_net/nss_ocsp_unittest.cc
diff --git a/net/cert_net/nss_ocsp_unittest.cc b/net/cert_net/nss_ocsp_unittest.cc
index d86e6a2e91e24fd345f15e2d4fe03a9f334bd102..c8cd63e452243b4274521ddd71344c4c7e87aac8 100644
--- a/net/cert_net/nss_ocsp_unittest.cc
+++ b/net/cert_net/nss_ocsp_unittest.cc
@@ -12,6 +12,7 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "base/test/scoped_async_task_scheduler.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
#include "net/cert/cert_status_flags.h"
@@ -124,6 +125,11 @@ class NssHttpTest : public ::testing::Test {
const CertificateList empty_cert_list_;
private:
+ // Required by MultiThreadedCertVerifier. Needs to be a
Ryan Sleevi 2017/02/07 22:52:09 This seems to be an undesirable coupling. It also
+ // ScopedAsyncTaskScheduler rather than a ScopedTaskScheduler because the task
+ // posted by MultiThreadedCertVerifier synchronously waits for a task running
+ // on the main thread (OCSPRequestSession::Wait).
+ base::test::ScopedAsyncTaskScheduler scoped_async_task_scheduler_;
TestURLRequestContext context_;
AiaResponseHandler* handler_;
scoped_refptr<CertVerifyProc> verify_proc_;

Powered by Google App Engine
This is Rietveld 408576698